Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A redacted message at the end of a thread is never read #26366

Closed
andybalaam opened this issue Oct 13, 2023 · 2 comments · Fixed by matrix-org/matrix-js-sdk#3798
Closed

A redacted message at the end of a thread is never read #26366

andybalaam opened this issue Oct 13, 2023 · 2 comments · Fixed by matrix-org/matrix-js-sdk#3798
Labels
A-Read-Marker Green line showing how far _you_ have read A-Redaction A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@andybalaam
Copy link
Contributor

andybalaam commented Oct 13, 2023 •
edited
Loading

  • As user A, look at some other room.
  • As user B, create a thread in a room with several messages in it.
  • As user B, redact the last message in the thread.
  • As user A, open the room and the thread.

User A sees the room as unread in the room list, even though they have read all messages.

I would expect the room to be read.

Testcase: "Reading an unread thread after a redaction of the latest message makes it read" in cypress/e2e/read-receipts/redactions.spec.ts.

Part of #24392
@andybalaam andybalaam mentioned this issue Oct 13, 2023
Closed
@andybalaam
Copy link
Contributor Author

andybalaam commented Oct 13, 2023 •
edited
Loading

Related: MSC3389: Relation redactions which proposes to preserve relation information through redactions.

@andybalaam
Copy link
Contributor Author

The problem here is that to be consistent with the spec (and the server) we need to move messages out of the thread when they are redacted. I will work on a change to do that.

This was referenced Oct 13, 2023
Merged
Merged
@robintown robintown added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist A-Redaction O-Occasional Affects or can be seen by some users regularly or most users rarely A-Threads A-Read-Marker Green line showing how far _you_ have read labels Oct 13, 2023
This was referenced Oct 17, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Read-Marker Green line showing how far _you_ have read A-Redaction A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move redacted messages out of any thread, into main timeline. matrix-org/matrix-js-sdk
2 participants
@andybalaam @robintown