Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room details: tab navigation #26597

Closed
Tracked by #25883
kerryarchibald opened this issue Nov 16, 2023 · 3 comments
Closed
Tracked by #25883

Room details: tab navigation #26597

kerryarchibald opened this issue Nov 16, 2023 · 3 comments

Comments

@kerryarchibald
Copy link
Contributor

kerryarchibald commented Nov 16, 2023

https://www.figma.com/file/rTaQE2nIUSLav4Tg3nozq7/Compound-Web-Components?type=design&node-id=667-440&mode=design&t=PifxQQLUULHatXkK-4

Screenshot 2023-11-16 at 17 52 38 Screenshot 2023-11-16 at 17 52 16 Screenshot 2023-11-16 at 17 52 01

Depends on element-hq/compound#201

AC:

  • room info view uses tab navigation that matches designs
  • Threads, files, people have tab navigation header
@kerryarchibald kerryarchibald changed the title [Tab navigation](https://www.figma.com/file/rTaQE2nIUSLav4Tg3nozq7/Compound-Web-Components?type=design&node-id=667-440&mode=design&t=PifxQQLUULHatXkK-4) missing Room details: tab navigation Nov 16, 2023
@dbkr
Copy link
Member

dbkr commented Jan 29, 2024

This feels like about a day, especially if we want to add a compound tab bar component (maybe a touch more then).

Edit: actually this is probably more to make a tab bar component) or adapt the horizontal one from roomdetails & put it into compound)

@daniellekirkwood
Copy link
Contributor

I think we can close this out, right @MidhunSureshR ? Is there anything left to do here ? :)

@MidhunSureshR
Copy link
Member

I think we can close this out, right @MidhunSureshR ? Is there anything left to do here ? :)

Yep :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants