Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Malformed reply can cause stuck notification #26787

Open
dbkr opened this issue Dec 18, 2023 · 0 comments
Open

Malformed reply can cause stuck notification #26787

dbkr opened this issue Dec 18, 2023 · 0 comments
Labels
A-Notifications O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@dbkr
Copy link
Member

dbkr commented Dec 18, 2023 •
edited
Loading

Steps to reproduce

If a (buggy) client sends (in a room with 'all messages' mode enabled) a reply to a threaded event but does not include the thread relation in the reply, this appears to cause element web to get stuck with a notification on the main room (but clear the unread status on the thread).

My guess at a cause: synapse does not class the message as being in the thread but Element does?

This was causing playwright tests to fail because the buggy client in question was our playwright message faking bot, which is how I discovered this (see matrix-org/matrix-react-sdk#12070).

Outcome

What did you expect?

Reading the thread should mark the room + thread as read

What happened instead?

Stuck notif badge on room

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@dbkr dbkr added the T-Defect label Dec 18, 2023
dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Dec 18, 2023
@dbkr
Fix threaded reply playwright tests
c6ad8b0 
It appears the bug with these tests was just that the MessageBuilder
wasn't setting the thread relation on the reply messages as this didn't
happen trying to repro it manually, so fix the builder and re-enable
the tests.

The flip side of this is that it implies buggy clients that don't
set thread relations properly will cause stuck notifs in Element Web.
I've filed this as element-hq/element-web#26787
@dbkr dbkr mentioned this issue Dec 18, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Dec 18, 2023
@dbkr
Fix threaded reply playwright tests (#12070)
24cda5f 
It appears the bug with these tests was just that the MessageBuilder
wasn't setting the thread relation on the reply messages as this didn't
happen trying to repro it manually, so fix the builder and re-enable
the tests.

The flip side of this is that it implies buggy clients that don't
set thread relations properly will cause stuck notifs in Element Web.
I've filed this as element-hq/element-web#26787
@florianduros florianduros added S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Notifications O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Notifications O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbkr @florianduros