Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrollback window seems to have become incredibly short #2752

Closed
ara4n opened this issue Dec 16, 2016 · 6 comments · Fixed by matrix-org/matrix-react-sdk#747
Closed

scrollback window seems to have become incredibly short #2752

ara4n opened this issue Dec 16, 2016 · 6 comments · Fixed by matrix-org/matrix-react-sdk#747
Labels
P2 S-Tolerable Low/no impact on users T-Defect X-Regression

Comments

@ara4n
Copy link
Member

ara4n commented Dec 16, 2016

only 1.5 pages of content for me before it starts discarding scrollback/scrollforward
@ara4n ara4n mentioned this issue Dec 18, 2016
Closed
@ara4n
Copy link
Member Author

ara4n commented Dec 20, 2016

@lukebarnard1 had some suggestions on how to tune this a bit.

@ara4n ara4n added T-Defect S-Tolerable Low/no impact on users X-Regression P2 and removed T-Defect labels Dec 20, 2016
@ara4n ara4n mentioned this issue Jan 12, 2017
Closed
@ara4n
Copy link
Member Author

ara4n commented Feb 19, 2017

this is in turn making #1146 even worse, causing #2896.

@lukebarnard1 am I imagining that you (or I) did something to improve this a bit?

@ara4n ara4n mentioned this issue Feb 19, 2017
Closed
@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Feb 20, 2017 •
edited
Loading

@ara4n I vaguely remember asking if I should do it and I thought the conclusion was that you would.

Ah, seems like you've doubled it. (matrix-org/matrix-react-sdk@2cf24c1)

It would be nice if features didn't rely on paginating events in (and I'm assuming it's not trivial to do otherwise).

@lukebarnard1
Copy link
Contributor

IRL: Double again

@lukebarnard1 lukebarnard1 mentioned this issue Mar 13, 2017
Merged
@lukebarnard1
Copy link
Contributor

Actually, I don't think the issues mentioned will be affected by the UNPAGINATION_PADDING. After all, it only modifies behaviour during un-pagination, which will not occur when an unseen room is shown for the first time in a while.

We may have to increase the initial number of events shown for each room.

@lukebarnard1 lukebarnard1 mentioned this issue Mar 17, 2017
Closed
@lukebarnard1 lukebarnard1 removed their assignment Nov 6, 2017
@richvdh
Copy link
Member

richvdh commented Apr 30, 2021

I think this can be closed?

@jryans jryans closed this as completed May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 S-Tolerable Low/no impact on users T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Double UNPAGINATION_PADDING again matrix-org/matrix-react-sdk
4 participants
@jryans @ara4n @richvdh @lukebarnard1