Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on another user's device prompts you to "manually verify it" #29062

Open
richvdh opened this issue Jan 21, 2025 · 5 comments
Open

Clicking on another user's device prompts you to "manually verify it" #29062

richvdh opened this issue Jan 21, 2025 · 5 comments
Labels
A-E2EE-Cross-Signing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@richvdh
Copy link
Member

richvdh commented Jan 21, 2025

  1. Open the profile of a user who has not been verified (or who has been verified and has an unverified device); see something like this:
    Image
  2. Click on "<N> sessions", to see the full session list
  3. Click on a device, marked with a grey shield. (Aside: shouldn't devices that actually haven't been verified by their owner be red, in keeping with the member list?)
  4. Observe this modal:
    Image

Clicking on "Interactively Verify by emoji" attempts to initiate a verification session with that specific device.

Problems:

  • It incorrectly says "signed in to a new session without verifying it", even when that is not the case.
  • We don't really want to be encouraging users to directly verify each other's devices
  • In any case "manually verify it" is confusing wording: we use that to refer to eyeballing the device key.
@dosubot dosubot bot added A-E2EE-SAS-Verification O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jan 21, 2025
@richvdh richvdh changed the title Clicking on another user's unverified device prompts you to "manually verify it" Clicking on another user's device prompts you to "manually verify it" Jan 21, 2025
@richvdh richvdh added O-Occasional Affects or can be seen by some users regularly or most users rarely A-E2EE-Cross-Signing and removed O-Uncommon Most users are unlikely to come across this or unexpected workflow A-E2EE-SAS-Verification labels Jan 22, 2025
@optim77
Copy link

optim77 commented Jan 22, 2025

May I ask about the security of this feauture, verifying someone else's unverified session, remotely, does not give any assurance that we are verifying the right person, is this safe, or am I missing something?

@t3chguy
Copy link
Member

t3chguy commented Jan 22, 2025

May I ask about the security of this feauture, verifying someone else's unverified session, remotely, does not give any assurance that we are verifying the right person, is this safe, or am I missing something?

The whole point of verification in an end-to-end system is to do it via an existing trusted mechanism, e.g. in person or via another verified means of communication. Otherwise it is pointless.

@optim77
Copy link

optim77 commented Jan 23, 2025

so remote verification of a person's unverified session is not secure. This can only be useful if we are physically able to verify the person and his device. I'm not sure it's right to suggest the possibility of verifying such a session to a user

@t3chguy
Copy link
Member

t3chguy commented Jan 23, 2025

Hence the prompt telling you to urge them to verify their own device...

@BillCarsonFr
Copy link
Member

Decision: we should remove this dialog for now, it is outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE-Cross-Signing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

4 participants