Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device dehydration: upgrade existing user accounts to add a dehydrated device #29080

Open
Tracked by #922
richvdh opened this issue Jan 23, 2025 · 1 comment
Open
Tracked by #922
Labels
A-E2EE-Dehydration O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement

Comments

@richvdh
Copy link
Member

richvdh commented Jan 23, 2025

If a user already has an account with recovery set up, and the dehydrated devices are enabled on the server, we currently have no way to correctly set up a dehydrated device for them.

Setting up a dehydrated device requires us to store the dehydrated device key in 4S.

This is mitigated for users that regularly log out all of their devices anyway (i.e., the main target users for this feature), because when they log in and verify with their recovery key, dehydration is set up correctly. However, this should be more robust, as the admin & users may expect it to be effective immediately after enabling on the server.

The potential failure case is:

  • Server admin enables dehydrated devices
  • Everyone assumes are now protected
  • They throw away their devices
  • They return from a longer vacation and log in a new device: turns out they were not protected and did not receive any messages during vacation.
@dosubot dosubot bot added A-E2EE-Dehydration O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Enhancement labels Jan 23, 2025
@richvdh
Copy link
Member Author

richvdh commented Jan 23, 2025

The likely solution to this is to prompt the user to enter their recovery key so that we can add the dehydrated device.

@richvdh richvdh added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jan 23, 2025
@richvdh richvdh changed the title Device dehydration: support adding dehydrated devices to existing user accounts Device dehydration: upgrade existing user accounts to add a dehydrated device Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE-Dehydration O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement
Projects
None yet
Development

No branches or pull requests

1 participant