Identity server settings are hidden when Posthog analytics is disabled

[reivilibre]

Steps to reproduce

1. Settings → Security & Privacy

see also

element-web/src/components/views/settings/tabs/user/SecurityUserSettingsTab.tsx

Lines 323 to 349 in a0044d6

	if (PosthogAnalytics.instance.isEnabled()) {
	const onClickAnalyticsLearnMore = (): void => {
	showAnalyticsLearnMoreDialog({
	primaryButton: _t("action|ok"),
	hasCancel: false,
	});
	};
	privacySection = (
	<SettingsSection heading={_t("common|privacy")}>
	<DiscoverySettings />
	<SettingsSubsection
	heading={_t("common|analytics")}
	description={_t("settings|security|analytics_description")}
	>
	<AccessibleButton kind="link" onClick={onClickAnalyticsLearnMore}>
	{_t("action|learn_more")}
	</AccessibleButton>
	{PosthogAnalytics.instance.isEnabled() && (
	<SettingsFlag name="pseudonymousAnalyticsOptIn" level={SettingLevel.ACCOUNT} />
	)}
	</SettingsSubsection>
	<SettingsSubsection heading={_t("settings|sessions|title")}>
	<SettingsFlag name="deviceClientInformationOptIn" level={SettingLevel.ACCOUNT} />
	</SettingsSubsection>
	</SettingsSection>
	);
	}

Line 332 is in the Posthog if block

Outcome

What did you expect?

to be able to manage my identity server associatons

What happened instead?

The Privacy section, including the IS section, is completely hidden.

Normally looks like:

With Posthog disabled:

Operating system

No response

Browser information

No response

URL for webapp

beta.matrix.org

Application version

Element version: 1.11.89 Crypto version: Rust SDK 0.7.2 (2f872cf), Vodozemac 0.8.1

Homeserver

beta.matrix.org

Will you send logs?

No

[t3chguy]

Index: src/components/views/settings/tabs/user/SecurityUserSettingsTab.tsx
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/src/components/views/settings/tabs/user/SecurityUserSettingsTab.tsx b/src/components/views/settings/tabs/user/SecurityUserSettingsTab.tsx
--- a/src/components/views/settings/tabs/user/SecurityUserSettingsTab.tsx	(revision a0044d6b5f841acd48870dcc99ff6f27f0248f61)
+++ b/src/components/views/settings/tabs/user/SecurityUserSettingsTab.tsx	(date 1737650648010)
@@ -319,7 +319,7 @@
             );
         }
 
-        let privacySection;
+        let posthogSection;
         if (PosthogAnalytics.instance.isEnabled()) {
             const onClickAnalyticsLearnMore = (): void => {
                 showAnalyticsLearnMoreDialog({
@@ -327,9 +327,8 @@
                     hasCancel: false,
                 });
             };
-            privacySection = (
-                <SettingsSection heading={_t("common|privacy")}>
-                    <DiscoverySettings />
+            posthogSection = (
+                <>
                     <SettingsSubsection
                         heading={_t("common|analytics")}
                         description={_t("settings|security|analytics_description")}
@@ -344,7 +343,7 @@
                     <SettingsSubsection heading={_t("settings|sessions|title")}>
                         <SettingsFlag name="deviceClientInformationOptIn" level={SettingLevel.ACCOUNT} />
                     </SettingsSubsection>
-                </SettingsSection>
+                </>
             );
         }
 
@@ -373,7 +372,10 @@
                     {crossSigning}
                     <CryptographyPanel />
                 </SettingsSection>
-                {privacySection}
+                <SettingsSection heading={_t("common|privacy")}>
+                    <DiscoverySettings />
+                    {posthogSection}
+                </SettingsSection>
                 {advancedSection}
             </SettingsTab>
         );

for future me or someone else