Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid guests from being stuck with numeric IDs #2947

Closed
ara4n opened this issue Jan 14, 2017 · 10 comments
Closed

Avoid guests from being stuck with numeric IDs #2947

ara4n opened this issue Jan 14, 2017 · 10 comments

Comments

@ara4n
Copy link
Member

ara4n commented Jan 14, 2017

It sucks that guests can't escape numeric ids without losing their history. Need to either:

  • support changing id
  • prompt guests for a username before they do anything
  • hide mxid so much they don't care about it being numeric
@ghost
Copy link

ghost commented Jan 15, 2017

This is a significant issue for me: I've been advocating and using Riot as a community organising hub for a makerspace, and the numeric IDs are actually breaking things really often.

  1. User comes to riot at my suggestion to join our public chatroom.
  2. User joins chatroom with new account, and we invite user to private chatroom.
  3. User changes username so they have something more personal than @\d\d\d\d\d\d\d\d:matrix.org
  4. User is no longer able to access either room, return to step 2.
  5. Moderator has to kick the old user-names.

@ara4n
Copy link
Member Author

ara4n commented Jan 15, 2017

@cathalgarvey thanks for the example failure mode. one temporary mitigation would be just to turn off guest access on your homeserver, which then forces users to pick a userid from the outset, and is close to the 2nd proposed solution on the original comment - but loses the "just get using the app" behaviour we have today.

Alternatively we could prompt just for userid on first use, but doing so without specifying a password feels a bit weird and risky, hence wondering if we should so a full signup. "hmm."

@ara4n
Copy link
Member Author

ara4n commented Feb 19, 2017

The right solution here is of course to let you migrate your user ID.

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Apr 13, 2017

So I think the solution we're going with now is

prompt guests for a username before they do anything

With the newly-suggested ROU -> PWLU-> Registered User flow (see element-hq/riot-meta#59)

@t3chguy
Copy link
Member

t3chguy commented Jun 12, 2017

Fixed by ILAG me thinks

@t3chguy t3chguy closed this as completed Jun 12, 2017
@martindale
Copy link

I'm still having this issue — see element-hq/riot-meta#210 for desired functionality. Generic numbers for guests is dehumanizing!

@t3chguy
Copy link
Member

t3chguy commented Jul 8, 2018

Guests are no longer used in riot-web so this is no longer an issue.
riot-web forces you to make a proper account by "Choosing a username"
it only uses guest accounts to peek into rooms before you choose a username.

@turt2live
Copy link
Member

When mixed with the autojoin option on synapse though, it's still an issue.

image

See also matrix-org/synapse#3491

@t3chguy
Copy link
Member

t3chguy commented Jul 8, 2018

The issue summary says one of three things needs to be done, option 2 was taken :/

@turt2live
Copy link
Member

Except that at least with autojoin, guests can speak and participate in channels. To be fair, I'm not advocating that this be re-opened, just that there's an edge case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants