Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Person who redacts a message has their read receipt disappear alongside the message #3511

Closed
turt2live opened this issue Mar 24, 2017 · 6 comments
Labels
P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@turt2live
Copy link
Member

Description

When someone redacts their message, their read receipt also disappears with it (if their read receipt was associated with it, such is the case if that was their most recent message).

Steps to reproduce

  • Send a message (note that this now becomes your most recently read message)
  • On another account, double check the read receipt is there
  • Redact the message
  • Note that the read receipt for the sender disappears

I would have expected their read receipt still stays linked to the message, as is the case with everyone else who has read up to that message.

Log: not sent

image

Above is a demonstration of the 'unexpected' behaviour: @Mikaela sent a message and Voyager (the blue airplane) saw it. Later on they redacted the message, but didn't send a later one until after my message 'sneaky'. Mikaela's avatar should have been next to the redacted message until they sent another message/read my message (at least).

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 56
  • OS: Windows 10
  • URL: riot.im/develop
@lampholder lampholder added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist P2 labels Mar 28, 2017
@turt2live turt2live changed the title Sender's read receipt disappears with redaction (/develop) Person who redacts a message has their read receipt disappear alongside the message Apr 20, 2017
@turt2live
Copy link
Member Author

This actually appears to be the person who performed the redaction has their RR disappear, not the person who sent the message. Was just a coincidence at the time of reporting.

Long shot guess of mine would be something to do with Riot unable to find the event after redacting and freaks out about sending the RR.

Title updated.

@turt2live
Copy link
Member Author

turt2live commented May 21, 2017

RR disappears even if their most recent read message is not the one redacted:

  • <someone> Hello world
  • <someone else> Hello indeed
  • <someone> redacts hello world
  • RR disappears from hello indeed

@t3chguy
Copy link
Member

t3chguy commented Jan 22, 2018

I guess their RR is now pointing at their m.room.redaction event because of js-sdk's implicit RR calculations; I'll look into this

@t3chguy
Copy link
Member

t3chguy commented Jan 24, 2018

I was right :D
js-sdk needs to ignore m.room.redaction when synthesising RRs

@turt2live
Copy link
Member Author

This seems to have gotten fixed (tested by sending a message on another account and redacting the message immediately after)

@t3chguy
Copy link
Member

t3chguy commented Mar 12, 2018

Yah fixed by above PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

3 participants