-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date and user have to be always printed on top of chat log #4780
Comments
Hi @iav, this is certainly the plan A similar issue relating to this is https://github.com/vector-im/riot-web/issues/3756 Let's use this issue to track "Sticky room headers and sticky user avatars in the timeline" |
Sticky avatars is #3902. @lukebarnard1: can that issue be closed in favour of this one? |
@uhoreg no harm in tracking them separately and using this to track both, I reckon |
Looks like @lukebarnard1 had a go at this in #4939 which had to be reverted in #4991 as the implementation is not ideal: it looks to try to constantly override the header offset onScroll rather than toggling Other thoughts:
Our prioritisation is all over the shop here: i thought element-hq/element-meta#1230 is P4; tom thought #3902 is P2 and luke thinks this one is P1. The fact we've ended up with overlapping bugs is also non-ideal, although given all of them now have useful info i guess we keep them all for now (although I'd prefer to have closed this one). |
(also, this issue is way way lower priority than communities/groups/flair imo). |
I'm not sure what I was thinking on that, but seemingly I felt it was p1 and I certainly don't in hindsight. This was more of a "Friday afternoon feature" that I wanted PR instead of leaving to gather dust. |
Closing in favor of #7575 |
Currently no date printed on a chat screen if no date change record located on a screen.
I think a date of a first line of text should always be printed on top of a chat log.
like
++++++ 25/11/2022 +++++
14:15 user: hello!
Same for a user: currently no username printed on a screen if there a wall of text typed by one user.
On a screenshot, area on a red owal – no user who typed text, no text date on screen.
The text was updated successfully, but these errors were encountered: