Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even simpler textarea composer #4861

Open
ara4n opened this issue Aug 23, 2017 · 14 comments
Open

Even simpler textarea composer #4861

ara4n opened this issue Aug 23, 2017 · 14 comments
Labels
A-Composer A-Pills O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Enhancement

Comments

@ara4n
Copy link
Member

ara4n commented Aug 23, 2017

for those who are hitting weird bugs like custom keybindings being ignored by Draft

@lukebarnard1
Copy link
Contributor

I'm not sure what disabling the RTE would look like...

@ara4n
Copy link
Member Author

ara4n commented Aug 25, 2017

I've had another request (due to it interacting badly with a 'privacy' extension). Disabling RTE would mean keeping the old Composer around for a bit longer, but just not turned on by default.

@lukebarnard1 lukebarnard1 self-assigned this Aug 26, 2017
@turt2live
Copy link
Member

This seems like the best releated issue, but someone in #riot would like to keep the emoji autocomplete, but not have the formatting keybindings. Would this solve that?

@eqyiel
Copy link

eqyiel commented Sep 3, 2017

Hey, I'm that someone from #riot.

The RTE is weird for people using MacOS/GTK with Emacs/readline keys.

For example, C-a should go to the start of the line, instead it highlights everything in the text field.

There are a bunch more like this.

@lukebarnard1
Copy link
Contributor

keeping the old Composer around for a bit longer, but just not turned on by default.

I'd be more inclined to try and make the new one work by improving it, perhaps optimising for customisation of keyboard shortcuts if that's what people are wanting the most.

@ara4n
Copy link
Member Author

ara4n commented Sep 18, 2017

I'd be more inclined to try and make the new one work by improving it,

I think this is going to be tough. Many of the complaints here are folks who had browser extensions which swap <textarea/> for some other richer editor. This one (custom keyboard shortcuts) is a bit more obscure. Can we just retrofit the textarea implementation into the new composer for folks who don't want fullblown Draft?

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Sep 19, 2017

Sure, I think we can still provide some of the auto-completion functionality whilst using a <textarea/>. Pills would be problematic.

Someone appears to be trying to make draft-js work for extensions in general - facebookarchive/draft-js#616 (comment) although it's not certain that this would solve our problems.

@ara4n
Copy link
Member Author

ara4n commented Sep 19, 2017

Yeah, i'm assuming pills and RTE(!) would disappear, but ideally keep the autocomplete UI.

@eqyiel
Copy link

eqyiel commented Oct 4, 2017

Another one of these: #5165

@non-Jedi
Copy link

non-Jedi commented Oct 7, 2017

Fixing this probably also fixes #4936 and #4909. Possibly others I'm missing.

@t3chguy
Copy link
Member

t3chguy commented Oct 16, 2017

Integrating autocomplete with textarea is somewhat more annoying than I had envisioned
but it is nearly done!!

@turt2live
Copy link
Member

@ara4n is this still a requirement given we now have slate and RTE/markdown are different modes?

@turt2live turt2live added X-Needs-Info This issue is blocked awaiting information from the reporter type:composer labels Oct 31, 2018
@t3chguy
Copy link
Member

t3chguy commented Mar 24, 2020

There is no longer an RTE.

@t3chguy t3chguy closed this as completed Mar 24, 2020
@non-Jedi
Copy link

@t3chguy the reason for this issue (behind the actual name) is people who use browser extensions that rely on there being a textarea for editable text. That is still a problem with the current Riot UI.

@t3chguy t3chguy changed the title ability to disable RTE Even simpler textarea composer Mar 24, 2020
@t3chguy t3chguy reopened this Mar 24, 2020
@jryans jryans added the A-Pills label Jun 23, 2020
@SimonBrandner SimonBrandner added O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed X-Needs-Info This issue is blocked awaiting information from the reporter P1 labels Aug 30, 2021
@t3chguy t3chguy removed the Z-RTE label Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer A-Pills O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Enhancement
Projects
None yet
Development

No branches or pull requests

9 participants