Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets get unvoluntarily removed by room moderators and admins #5115

Closed
almereyda opened this issue Sep 24, 2017 · 6 comments
Closed

Widgets get unvoluntarily removed by room moderators and admins #5115

almereyda opened this issue Sep 24, 2017 · 6 comments
Assignees
Labels
A-Widgets P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround

Comments

@almereyda
Copy link

Description

Since the introduction of widgets into some of our rooms, other moderators and administrators of those repeatingly remove widgets without wanting to, as they believe the X will fold it, instead of removing it.

Steps to reproduce

  • add a widget to a room with other moderators that don't know about widgets, yet
  • wait a while, until someone will try to fold it, and unexpectedly removes it

There could be a confirmation dialogue repeating the intent, offering an OK button and allowing for cancel.

Version information

riot-web v0.12.3

This touches with:

@pafcu
Copy link
Contributor

pafcu commented Sep 24, 2017

Perhaps change the X to a more universally understood icon, such as a trashcan?

@lampholder lampholder added S-Major Severely degrades major functionality or product features, with no satisfactory workaround P1 A-Widgets ui/ux labels Sep 25, 2017
@lampholder
Copy link
Member

We do need to spend some time refining the UX, but either a trashcan icon or a confirmation 'are you sure you want to remove this widget from this room?' would help to mitigate this particular problem.

@almereyda
Copy link
Author

To also resolve #4839, it may be also good to

  • create an issue for an option for collapsing widgets upon channel display by default, and on a per-user basis.

@rxl881
Copy link
Contributor

rxl881 commented Oct 23, 2017

I have addressed the icon (trash can) and warning / confirmation dialog in:
Riot-web: #5397
Matrix-react-sdk: matrix-org/matrix-react-sdk#1520

@uhoreg
Copy link
Member

uhoreg commented Nov 14, 2017

@rxl881 since the PRs are merged, can this be closed?

@rxl881
Copy link
Contributor

rxl881 commented Nov 14, 2017

@uhoreg - Yes. Thanks for spotting :)

@rxl881 rxl881 closed this as completed Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Widgets P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround
Projects
None yet
Development

No branches or pull requests

5 participants