Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinned messages don't seem to update in realtime #5358

Closed
ara4n opened this issue Oct 19, 2017 · 2 comments · Fixed by matrix-org/matrix-react-sdk#1934
Closed

Pinned messages don't seem to update in realtime #5358

ara4n opened this issue Oct 19, 2017 · 2 comments · Fixed by matrix-org/matrix-react-sdk#1934
Labels
P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Oct 19, 2017

Pin events don't seem to kick the panel into refreshing. Also may need a spinner or UI of some kind to show within the timeline whether the pinning worked or not
@turt2live
Copy link
Member

:( this was working before.

I'll take a look tonight during my riot-update spree.

@turt2live
Copy link
Member

Apparently I never implemented this, which is unfortunate :(

I believe the panel just needs to listen for RoomState.events and filter on m.room.pinned_events, forcing an update of the pinned events (so it can re-use the filtering).

Unless someone beats me to it, I'll work on this in the late weekend.

@lampholder lampholder added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround P2 ui/ux labels Oct 23, 2017
@lampholder lampholder mentioned this issue May 15, 2023
Closed
14 tasks
@turt2live turt2live mentioned this issue May 27, 2018
Merged
@HarHarLinks HarHarLinks mentioned this issue Apr 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update pinned messages in real time turt2live/matrix-react-sdk
3 participants
@turt2live @ara4n @lampholder