Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replying to a message with an emote doesn't look like an emote #6061

Closed
turt2live opened this issue Jan 29, 2018 · 6 comments
Closed

Replying to a message with an emote doesn't look like an emote #6061

turt2live opened this issue Jan 29, 2018 · 6 comments
Labels
A-Replies reply P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@turt2live
Copy link
Member

Description

image

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 63
  • OS: Windows 10
  • URL: riot.im/develop
@t3chguy
Copy link
Member

t3chguy commented Jan 29, 2018

soooo this further pushes me to wanting to have the replying semantic entirely out of the text/html representation of the event
otherwise this is the only sane rendering of a reply which remote matches what is on the wire

edit:
i.e a content.replyingTo field on m.room.message ev's

@t3chguy
Copy link
Member

t3chguy commented Jan 29, 2018

@lampholder ideas on how best to render a reply in the form of an emote?

@lampholder
Copy link
Member

What about instead of:

image

just:

image

?

Easy to draw in gimp; perhaps a lot fiddlier to realise in code?

@lampholder lampholder added T-Defect P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Replies reply labels Jan 31, 2018
@lampholder
Copy link
Member

AS discussed IRL, the sender then isn't at the top of the message, which is problematic.

@lampholder
Copy link
Member

I think this might actually be fine.

If the emote-reply is the first thing User X has said after other users have been speaking, it'll have their avatar there.

If the emote-reply is not the first thing User X has said after other users have been speaking, the reply won't have an avatar/display name near it. However, I don't think this looks materially weirder than a standard emote.

I reckon we try implementing it as per the mocked up screenshot above and see how we go.

@t3chguy
Copy link
Member

t3chguy commented May 4, 2018

It is no longer possible to reply with an emote as you cannot write a sane PR for it, but the app will render it well if someone sends an emote reply without a fallback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Replies reply P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

3 participants