-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replying to a message with an emote doesn't look like an emote #6061
Comments
soooo this further pushes me to wanting to have the replying semantic entirely out of the text/html representation of the event edit: |
@lampholder ideas on how best to render a reply in the form of an emote? |
AS discussed IRL, the sender then isn't at the top of the message, which is problematic. |
I think this might actually be fine. If the emote-reply is the first thing User X has said after other users have been speaking, it'll have their avatar there. If the emote-reply is not the first thing User X has said after other users have been speaking, the reply won't have an avatar/display name near it. However, I don't think this looks materially weirder than a standard emote. I reckon we try implementing it as per the mocked up screenshot above and see how we go. |
It is no longer possible to reply with an emote as you cannot write a sane PR for it, but the app will render it well if someone sends an emote reply without a fallback. |
Description
Version information
The text was updated successfully, but these errors were encountered: