Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll jumping when back paginating #6265

Closed
lampholder opened this issue Feb 28, 2018 · 9 comments
Closed

Scroll jumping when back paginating #6265

lampholder opened this issue Feb 28, 2018 · 9 comments
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Platform-Specific

Comments

@lampholder
Copy link
Member

Reported by @AmandineLP

Pagination is broken when I try to scroll back too quickly.

If I scroll back too quickly in a room, at some point (I assume when I reach the end of what is cached) the timeline only jumps slightly up and down, as if trying to find the right place to be. I have to wait several seconds to be able to start scrolling again.

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Feb 28, 2018

Would be really useful to know which peripheral(mouse/trackpad)/OS/browser/version we're talking about here!

@AmandineLP
Copy link
Contributor

AmandineLP commented Mar 5, 2018

Sorry I thought this was a rageshake. Using trackpad on my macbook air, in Chrome (64 today). I can show you IRL when I reproduce. I've been reproducing on several versions of Riot, and I think only e2e rooms

@lukebarnard1
Copy link
Contributor

Oh my bad, I didn't see the ref to the rageshake.

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Mar 5, 2018

trackpad on my macbook air

I have to say that I've witnessed the same on my Mac and I think the conclusion was that it would require a rewrite of our scroll component (ScrollPanel).

In short, the Mac fires scroll events at a very high frequency which makes it likely for one to fire immediately after a scroll jump has occurred - the panel then takes this incorrect position as truth because we save it.

@lukebarnard1
Copy link
Contributor

This is related to #2646

@lukebarnard1 lukebarnard1 changed the title Pagination is broken when scrolling back too quickly. Scroll jumping when back paginating Mar 5, 2018
@lampholder lampholder added T-Defect ui/ux P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround Z-Platform-Specific labels Mar 6, 2018
@ara4n ara4n added P1 and removed P2 labels May 19, 2018
@ara4n
Copy link
Member

ara4n commented May 19, 2018

this is really sucking - i'm seeing jumps of several pages when I backpaginate.

@ara4n
Copy link
Member

ara4n commented Jan 15, 2019

@lampholder says this has got worse since /experimental; for me it's got better. i'm going to investigate.

@lukebarnard1
Copy link
Contributor

This is still quite bad for me. (Hello again btw! 😄)

I think my last thinking on it was that a potential fix would be chrome's scroll-anchoring becoming widely implemented in browsers. Although, they seem to be struggling with certain known bugs in the current implementation, namely a bug related to react-based infinite scrolling...

@ara4n
Copy link
Member

ara4n commented May 1, 2019

this has been eclipsed by #8565

@ara4n ara4n closed this as completed May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Platform-Specific
Projects
None yet
Development

No branches or pull requests

4 participants