Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme avatars should have brighter background color for transparent images #8558

Closed
bwindels opened this issue Feb 13, 2019 · 2 comments

Comments

@bwindels
Copy link
Contributor

As most transparent avatars seem to assume a light background.

image

@ara4n
Copy link
Member

ara4n commented Feb 13, 2019

i think this is incorrect, as per #8425.

tl;dr:

  • if you want your avatar to have a light background, you should upload one with a light background.
  • if you want your avatar to have a dark background, you should upload one with a dark background.
  • if you want your avatar to have a transparent background so that it fits into both light and dark themes, you need to design the artwork to work on both light and dark backgrounds (e.g. not upload a black-on-transparent avatar and then wonder why it's invisible in a dark theme).

@ara4n ara4n closed this as completed Feb 13, 2019
@rxl881
Copy link
Contributor

rxl881 commented Feb 13, 2019

I think that @matthew is right, but there will be a lot of existing avatars out there that will look pretty broken / invisible in the current setup. Could this be fixed by adding a hairline border (with the same colour as the room list separators) around the avatars, so that at least you can see that they are there, regardless of the content?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants