Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider making key request uisi warnings a spinner rather than a warning #9080

Closed
ara4n opened this issue Mar 7, 2019 · 2 comments
Closed
Labels
A-E2EE P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Mar 7, 2019

eg 'loading keys... rerequest?' rather than 'cannot load keys'

@lampholder
Copy link
Member

Worth thinking about, but I think we should take a step back and look at what message we're trying to send about UISIs.

Spinners say "this is in progress, you can expect to see this resolve without your intervention (and soon)". Spinners are also annoying if they sit spinning indefinitely.

My ideal UISI message might:

  • show that the message is currently undecryptable
  • show a spinner whilst waiting for key share requests from other devices
  • show me which devices it heard back from confirming that they don't have a copy of the key
    • give me an option to trigger another key request (perhaps with instructions based on the above: "check devices x, y, z to see if they're turned on/have waiting key share requests")
  • show me whether a copy of the key exists in the backup
  • tell me whether this message was just never encrypted for me by the sender

@lampholder lampholder added ui/ux P2 S-Minor Impairs non-critical functionality or suitable workarounds exist A-E2EE T-Defect labels Mar 15, 2019
@jryans jryans removed the Z-UI/UX label Mar 9, 2021
@turt2live
Copy link
Member

Closing in favour of #20532

@turt2live turt2live closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

4 participants