Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed reaction events show 'message not sent' error #9755

Closed
Half-Shot opened this issue May 17, 2019 · 4 comments
Closed

Failed reaction events show 'message not sent' error #9755

Half-Shot opened this issue May 17, 2019 · 4 comments
Labels
A-Aggregations A-Reactions T-Defect

Comments

@Half-Shot
Copy link
Member

I was spamming thumbs on a message and then it popped up, I guess it shouldn't do that
@jryans
Copy link
Collaborator

jryans commented May 20, 2019

We haven't really defined how error handling should work for reactions, so maybe we can use this as chance to do so.

@jryans
Copy link
Collaborator

jryans commented May 20, 2019

@nadonomy / @lampholder, should reactions show error messages in the same ways as messages do, or should something else happen?

@nadonomy
Copy link
Contributor

@nadonomy / @lampholder, should reactions show error messages in the same ways as messages do, or should something else happen?

Great question. Will message you on Riot to ensure we have a shared understanding of what happens with messages today to figure it out from there.

@jryans
Copy link
Collaborator

jryans commented May 20, 2019

Let's consider this a duplicate of #9692, where we plan to do something about reaction errors generally.

@jryans jryans closed this as completed May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Aggregations A-Reactions T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jryans @Half-Shot @nadonomy