Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect escaping of IRC(?) nicknames #9771

Closed
joepie91 opened this issue May 20, 2019 · 2 comments
Closed

Incorrect escaping of IRC(?) nicknames #9771

joepie91 opened this issue May 20, 2019 · 2 comments

Comments

@joepie91
Copy link

Description

Nicknames from IRC(?) get incorrectly escaped for certain special characters.

Steps to reproduce

  • Enter #freenode_#bottest:matrix.org
  • Post a GitHub link, like https://github.com/vector-im/riot-web/issues/7134, wait for the bot to respond with the issue title
  • Notice the wrong bot nickname :)

Original on IRC:

[10:56] <joepie91[m]> sphalerite: https://github.com/vector-im/riot-web/issues/7134 :)
[10:56] <{^_^}> vector-im/riot-web#7134 (by turt2live, 41 weeks ago, open): Pills for users with backticks get converted to code when complimented with another backtick

Bot nickname display in Riot (desktop):

Selection_0017

As you can see, some sort of encoding happens in the process, and turns the { into =7b, and the } into =7d. This should be displayed as {^_^} instead of =7b^_^=7d.

I don't know whether this is a bug in the IRC bridge or in Riot.

Log: not sent

Version information

  • Platform: desktop

  • OS: NixOS 18.09, Riot desktop installed from unstable nixpkgs channel

  • Version: matrix-react-sdk version: / riot-web version: 1.0.8 / olm version: 3.0.0

@jryans
Copy link
Collaborator

jryans commented May 20, 2019

This looks to be a duplicate of #9662, where it was mentioned that the actual issue is tracked at matrix-org/matrix-appservice-irc#749, so it's a bridge issue.

@jryans jryans closed this as completed May 20, 2019
@joepie91
Copy link
Author

Ah, I didn't find that issue in my search. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants