Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated MatrixClient.keyBackupKeyFromPassword call. #28233

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Remove deprecated MatrixClient.keyBackupKeyFromPassword call. #28233

merged 1 commit into from
Oct 21, 2024

Conversation

florianduros
Copy link
Member

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Task #26922

  • The keyBackupKeyFromPassword call is bound to the keyCallback props which is not used in CreateSecretStorageDialog
  • Remove code bound to keyCallback props

@florianduros florianduros mentioned this pull request Oct 18, 2024
Open
@florianduros florianduros added the T-Task Tasks for the team like planning label Oct 18, 2024
@florianduros
- Remove deprecated MatrixClient.keyBackupKeyFromPassword call.
b636f02 
- The `keyBackupKeyFromPassword` call is bound to the `keyCallback` props in `RestoreKeyBackupDialog` which is not used in `CreateSecretStorageDialog`
- Remove code bound to `keyCallback` props
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/remove-keyBackupKeyFromPassword-call branch from 635e991 to b636f02 Compare October 18, 2024 09:55
@florianduros florianduros marked this pull request as ready for review October 18, 2024 10:16
@florianduros florianduros requested review from a team as code owners October 18, 2024 10:16
@andybalaam andybalaam removed the request for review from richvdh October 21, 2024 09:57
@florianduros florianduros added this pull request to the merge queue Oct 21, 2024
Merged via the queue into develop with commit 061c821 Oct 21, 2024
40 checks passed
@florianduros florianduros deleted the florianduros/rip-out-legacy-crypto/remove-keyBackupKeyFromPassword-call branch October 21, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@andybalaam andybalaam andybalaam approved these changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florianduros @andybalaam @t3chguy