Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework UrlPreviewSettings to use MatrixClient.CryptoApi.isEncryptionEnabledInRoom #28463

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Rework UrlPreviewSettings to use MatrixClient.CryptoApi.isEncryptionEnabledInRoom #28463

merged 5 commits into from
Nov 20, 2024

Conversation

florianduros
Copy link
Member

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Task #26922
Rewrite UrlPreviewSettings into a functional component and add tests

@florianduros florianduros mentioned this pull request Nov 14, 2024
Open
@florianduros florianduros added the T-Task Tasks for the team like planning label Nov 14, 2024
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/migrate-urlpreviewsettings branch from d2b8446 to 9a3c410 Compare November 14, 2024 16:11
@florianduros florianduros marked this pull request as ready for review November 14, 2024 16:50
@florianduros florianduros requested a review from a team as a code owner November 14, 2024 16:50
@florianduros florianduros requested a review from t3chguy November 18, 2024 13:50
@florianduros florianduros requested a review from a team as a code owner November 20, 2024 16:44
@florianduros florianduros requested a review from t3chguy November 20, 2024 16:44
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/migrate-urlpreviewsettings branch from 7ee37f8 to 7ba528f Compare November 20, 2024 16:50
@florianduros florianduros added this pull request to the merge queue Nov 20, 2024
Merged via the queue into develop with commit d5c111f Nov 20, 2024
32 checks passed
@florianduros florianduros deleted the florianduros/rip-out-legacy-crypto/migrate-urlpreviewsettings branch November 20, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @t3chguy