Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second batch: Replace MatrixClient.isRoomEncrypted by MatrixClient.CryptoApi.isEncryptionEnabledInRoom #28466

Merged
merged 14 commits into from
Nov 20, 2024
Merged

Second batch: Replace MatrixClient.isRoomEncrypted by MatrixClient.CryptoApi.isEncryptionEnabledInRoom #28466

merged 14 commits into from
Nov 20, 2024

Conversation

florianduros
Copy link
Member

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Task #26922
Replace MatrixClient.isRoomEncrypted by MatrixClient.CryptoApi.isEncryptionEnabledInRoom

@florianduros
Add asyncFilter
6533a6b
@florianduros
Replace MatrixClient.isRoomEncrypted by `MatrixClient.CryptoApi.isE…
f8c5eac 
…ncryptionEnabledInRoom` in `MemberListStore.tsx`
@florianduros
Replace MatrixClient.isRoomEncrypted by `MatrixClient.CryptoApi.isE…
d7ef409 
…ncryptionEnabledInRoom` in `EventIndex.tsx`
@florianduros
Replace MatrixClient.isRoomEncrypted by `MatrixClient.CryptoApi.isE…
6bf06da 
…ncryptionEnabledInRoom` in `SendMessageComposer.tsx`
@florianduros
Replace MatrixClient.isRoomEncrypted by `MatrixClient.CryptoApi.isE…
de765bb 
…ncryptionEnabledInRoom` in `ScalarMessaging.ts`
@florianduros
Replace MatrixClient.isRoomEncrypted by `MatrixClient.CryptoApi.isE…
a0d0fa7 
…ncryptionEnabledInRoom` in `RolesRoomSettingsTab.tsx`
@florianduros florianduros mentioned this pull request Nov 14, 2024
Open
@florianduros florianduros added the T-Task Tasks for the team like planning label Nov 14, 2024
@florianduros florianduros marked this pull request as ready for review November 14, 2024 17:20
@florianduros florianduros requested a review from a team as a code owner November 14, 2024 17:20
t3chguy
t3chguy requested changes Nov 14, 2024
View reviewed changes
src/utils/arrays.ts Outdated Show resolved Hide resolved
src/ScalarMessaging.ts Outdated Show resolved Hide resolved
src/components/views/settings/tabs/room/RolesRoomSettingsTab.tsx Show resolved Hide resolved
src/stores/MemberListStore.ts Outdated Show resolved Hide resolved
src/components/views/rooms/SendMessageComposer.tsx Outdated Show resolved Hide resolved
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/2-remove-isRoomEncrypted branch from 263b3a0 to 4d4e037 Compare November 19, 2024 16:02
@florianduros
Revert "Display composer only after isEncrypted is computed"
cfd0ae1 
This reverts commit 4d4e037.
@florianduros
Revert "Replace MatrixClient.isRoomEncrypted by `MatrixClient.Crypt…
88536b1 
…oApi.isEncryptionEnabledInRoom` in `SendMessageComposer.tsx`"

This reverts commit 6bf06da.
@florianduros
Copy link
Member Author

I'm reverting the changes to the composer. It will need more work in a dedicated PR.

@florianduros florianduros requested a review from t3chguy November 20, 2024 09:19
@florianduros florianduros added this pull request to the merge queue Nov 20, 2024
Merged via the queue into develop with commit 5cdcf44 Nov 20, 2024
34 checks passed
@florianduros florianduros deleted the florianduros/rip-out-legacy-crypto/2-remove-isRoomEncrypted branch November 20, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @t3chguy