From 85273d99e5c76fc12e1fac1bf278d69db2e4fd65 Mon Sep 17 00:00:00 2001
From: Flavio Alescio <flavioale@element.io>
Date: Mon, 15 May 2023 10:22:11 +0200
Subject: [PATCH] UI section title fix

---
 .../Sources/Screens/CreateRoom/View/CreateRoomScreen.swift    | 4 +++-
 UITests/Sources/CreateRoomScreenUITests.swift                 | 3 ++-
 .../Application/en-GB-iPad-9th-generation.createRoom-0.png    | 4 ++--
 .../Application/en-GB-iPad-9th-generation.createRoom-1.png    | 4 ++--
 .../Application/en-GB-iPad-9th-generation.createRoom-2.png    | 4 ++--
 .../Application/en-GB-iPad-9th-generation.createRoom-3.png    | 4 ++--
 .../Application/en-GB-iPhone-14.createRoom-0.png              | 4 ++--
 .../Application/en-GB-iPhone-14.createRoom-1.png              | 4 ++--
 .../Application/en-GB-iPhone-14.createRoom-2.png              | 4 ++--
 .../Application/en-GB-iPhone-14.createRoom-3.png              | 3 ---
 .../Application/pseudo-iPad-9th-generation.createRoom-0.png   | 4 ++--
 .../Application/pseudo-iPad-9th-generation.createRoom-1.png   | 4 ++--
 .../Application/pseudo-iPad-9th-generation.createRoom-2.png   | 4 ++--
 .../Application/pseudo-iPad-9th-generation.createRoom-3.png   | 4 ++--
 .../Application/pseudo-iPhone-14.createRoom-0.png             | 4 ++--
 .../Application/pseudo-iPhone-14.createRoom-1.png             | 4 ++--
 .../Application/pseudo-iPhone-14.createRoom-2.png             | 4 ++--
 .../Application/pseudo-iPhone-14.createRoom-3.png             | 3 ---
 18 files changed, 33 insertions(+), 36 deletions(-)
 delete mode 100644 UITests/Sources/__Snapshots__/Application/en-GB-iPhone-14.createRoom-3.png
 delete mode 100644 UITests/Sources/__Snapshots__/Application/pseudo-iPhone-14.createRoom-3.png

diff --git a/ElementX/Sources/Screens/CreateRoom/View/CreateRoomScreen.swift b/ElementX/Sources/Screens/CreateRoom/View/CreateRoomScreen.swift
index aa1039ecf9..24f721fd32 100644
--- a/ElementX/Sources/Screens/CreateRoom/View/CreateRoomScreen.swift
+++ b/ElementX/Sources/Screens/CreateRoom/View/CreateRoomScreen.swift
@@ -56,7 +56,7 @@ struct CreateRoomScreen: View {
                     .clipShape(Circle())
                 VStack(alignment: .leading, spacing: 8) {
                     Text(L10n.screenCreateRoomRoomNameLabel.uppercased())
-                        .font(.compound.bodySM)
+                        .font(.compound.bodyXS)
                         .padding(.leading, 16)
                         .formSectionHeader()
                     TextField(L10n.screenCreateRoomRoomNameLabel,
@@ -85,6 +85,7 @@ struct CreateRoomScreen: View {
                 .lineLimit(3, reservesSpace: false)
         } header: {
             Text(L10n.screenCreateRoomTopicLabel)
+                .formSectionHeader()
         } footer: {
             if !context.viewState.selectedUsers.isEmpty {
                 selectedUsersSection
@@ -143,6 +144,7 @@ struct CreateRoomScreen: View {
             .pickerStyle(.inline)
         } header: {
             Text(L10n.commonSecurity.uppercased())
+                .formSectionHeader()
         }
         .formSectionStyle()
     }
diff --git a/UITests/Sources/CreateRoomScreenUITests.swift b/UITests/Sources/CreateRoomScreenUITests.swift
index 850bae415c..76a3d264c1 100644
--- a/UITests/Sources/CreateRoomScreenUITests.swift
+++ b/UITests/Sources/CreateRoomScreenUITests.swift
@@ -38,7 +38,8 @@ class CreateRoomScreenUITests: XCTestCase {
     func testLongInputTopicText() {
         let app = Application.launch(.createRoom)
         let roomTopic = "Room topic\nvery\nvery\nvery long"
-        app.textViews[A11yIdentifiers.createRoomScreen.roomTopic].clearAndTypeText(roomTopic)
+        app.textViews[A11yIdentifiers.createRoomScreen.roomTopic].tap()
+        app.textViews[A11yIdentifiers.createRoomScreen.roomTopic].typeText(roomTopic)
         app.assertScreenshot(.createRoom, step: 3)
     }
 }
diff --git a/UITests/Sources/__Snapshots__/Application/en-GB-iPad-9th-generation.createRoom-0.png b/UITests/Sources/__Snapshots__/Application/en-GB-iPad-9th-generation.createRoom-0.png
index 7910e4f5b5..89df187cc2 100644
--- a/UITests/Sources/__Snapshots__/Application/en-GB-iPad-9th-generation.createRoom-0.png
+++ b/UITests/Sources/__Snapshots__/Application/en-GB-iPad-9th-generation.createRoom-0.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:e6df5a4b0835895c39f5a036ad83a8ce07953943bee6e23ee337c820f2655103
-size 141995
+oid sha256:30a57a7906568df2b6ba4160041b410fe0eb242e3991670f2523b9dd7bdd66e0
+size 142197
diff --git a/UITests/Sources/__Snapshots__/Application/en-GB-iPad-9th-generation.createRoom-1.png b/UITests/Sources/__Snapshots__/Application/en-GB-iPad-9th-generation.createRoom-1.png
index 078e0fc9c9..aedd789934 100644
--- a/UITests/Sources/__Snapshots__/Application/en-GB-iPad-9th-generation.createRoom-1.png
+++ b/UITests/Sources/__Snapshots__/Application/en-GB-iPad-9th-generation.createRoom-1.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:5557c20994afe27635dcb27896d882e06516f25bd09169daa238d1fbdae3398a
-size 119317
+oid sha256:b3bcc5ad6895274acbc571fed907c519adb3fbf8af9d24483e5e7ab787ceafee
+size 119395
diff --git a/UITests/Sources/__Snapshots__/Application/en-GB-iPad-9th-generation.createRoom-2.png b/UITests/Sources/__Snapshots__/Application/en-GB-iPad-9th-generation.createRoom-2.png
index 055ac5579e..8ca02a5f9f 100644
--- a/UITests/Sources/__Snapshots__/Application/en-GB-iPad-9th-generation.createRoom-2.png
+++ b/UITests/Sources/__Snapshots__/Application/en-GB-iPad-9th-generation.createRoom-2.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:25ee42f25f683400186a4f73276087d8d3a97d6e1143ee5a5e7e8cc07bc6b6f4
-size 139565
+oid sha256:eb277e2c6e781270230f19d828c32dedae6b010d4ac3946f50f38afb1caca302
+size 139805
diff --git a/UITests/Sources/__Snapshots__/Application/en-GB-iPad-9th-generation.createRoom-3.png b/UITests/Sources/__Snapshots__/Application/en-GB-iPad-9th-generation.createRoom-3.png
index eb176c3cf8..bfd1a05926 100644
--- a/UITests/Sources/__Snapshots__/Application/en-GB-iPad-9th-generation.createRoom-3.png
+++ b/UITests/Sources/__Snapshots__/Application/en-GB-iPad-9th-generation.createRoom-3.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:8ae40b042699968252d3ccec09c2f186422c3ac0ce6b9a23335f560499d5fe26
-size 213547
+oid sha256:c7fa8b455dc006e3a64b4259164e02bf621d05481770414e29238fe1ffd1f58e
+size 216487
diff --git a/UITests/Sources/__Snapshots__/Application/en-GB-iPhone-14.createRoom-0.png b/UITests/Sources/__Snapshots__/Application/en-GB-iPhone-14.createRoom-0.png
index df21141a76..899233b662 100644
--- a/UITests/Sources/__Snapshots__/Application/en-GB-iPhone-14.createRoom-0.png
+++ b/UITests/Sources/__Snapshots__/Application/en-GB-iPhone-14.createRoom-0.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:5fa84fc2b9e3bf1de16dcac03cae8ddc6ab367c6a8d700dc17f3b911db5f7139
-size 188055
+oid sha256:6aa6558475e3dca45b3969d31826bad20ae726c6cce9f2daee8d536129ddcf81
+size 184940
diff --git a/UITests/Sources/__Snapshots__/Application/en-GB-iPhone-14.createRoom-1.png b/UITests/Sources/__Snapshots__/Application/en-GB-iPhone-14.createRoom-1.png
index 9bed385b6a..3d13bc0af0 100644
--- a/UITests/Sources/__Snapshots__/Application/en-GB-iPhone-14.createRoom-1.png
+++ b/UITests/Sources/__Snapshots__/Application/en-GB-iPhone-14.createRoom-1.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:5bb5d31ab43bd6766306464bfbd7915accaf560b0069d19ee450d2721addc4a3
-size 155277
+oid sha256:4cd0921da82ea2a1ee28bfe36c98ef62128e49f9f2244966f45f80d46512f512
+size 156826
diff --git a/UITests/Sources/__Snapshots__/Application/en-GB-iPhone-14.createRoom-2.png b/UITests/Sources/__Snapshots__/Application/en-GB-iPhone-14.createRoom-2.png
index 5b38479cec..4d31f4242b 100644
--- a/UITests/Sources/__Snapshots__/Application/en-GB-iPhone-14.createRoom-2.png
+++ b/UITests/Sources/__Snapshots__/Application/en-GB-iPhone-14.createRoom-2.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:4378f4181c0a34c6d9bce0c51d88c8162a1f5570a3751e0939ab0dbe152165eb
-size 182272
+oid sha256:7996f7d75665cff1a4f2ed5317a0f0a9a0adf70cf04eb6aa555c945a344421ea
+size 181498
diff --git a/UITests/Sources/__Snapshots__/Application/en-GB-iPhone-14.createRoom-3.png b/UITests/Sources/__Snapshots__/Application/en-GB-iPhone-14.createRoom-3.png
deleted file mode 100644
index 6fd8b572da..0000000000
--- a/UITests/Sources/__Snapshots__/Application/en-GB-iPhone-14.createRoom-3.png
+++ /dev/null
@@ -1,3 +0,0 @@
-version https://git-lfs.github.com/spec/v1
-oid sha256:65d4ff5bf36a0da77ff4ca8b9f37508ddc3a420f4537cbf4f0eb1b8e8db1246e
-size 212688
diff --git a/UITests/Sources/__Snapshots__/Application/pseudo-iPad-9th-generation.createRoom-0.png b/UITests/Sources/__Snapshots__/Application/pseudo-iPad-9th-generation.createRoom-0.png
index 22ae413e52..359866e00c 100644
--- a/UITests/Sources/__Snapshots__/Application/pseudo-iPad-9th-generation.createRoom-0.png
+++ b/UITests/Sources/__Snapshots__/Application/pseudo-iPad-9th-generation.createRoom-0.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:35b0814944765d14aeb6196dd58b00f30f327347ca9a342d5b4cf51237d70a93
-size 171345
+oid sha256:00afe2fb3c7916cb27095ee0c68141f55169ef08145176cda0eff31cc1dc6112
+size 170654
diff --git a/UITests/Sources/__Snapshots__/Application/pseudo-iPad-9th-generation.createRoom-1.png b/UITests/Sources/__Snapshots__/Application/pseudo-iPad-9th-generation.createRoom-1.png
index 843b4c7eb1..2be9db20f8 100644
--- a/UITests/Sources/__Snapshots__/Application/pseudo-iPad-9th-generation.createRoom-1.png
+++ b/UITests/Sources/__Snapshots__/Application/pseudo-iPad-9th-generation.createRoom-1.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:7092d1228d25e650595b07d6bdba7eb5ae9619af5c769a28544cc456817fbf10
-size 149594
+oid sha256:5a3044792fc93c2b662b03ffe34d4fcd386547196fa6e06417006d406845d011
+size 148728
diff --git a/UITests/Sources/__Snapshots__/Application/pseudo-iPad-9th-generation.createRoom-2.png b/UITests/Sources/__Snapshots__/Application/pseudo-iPad-9th-generation.createRoom-2.png
index fb8181c234..ac93338714 100644
--- a/UITests/Sources/__Snapshots__/Application/pseudo-iPad-9th-generation.createRoom-2.png
+++ b/UITests/Sources/__Snapshots__/Application/pseudo-iPad-9th-generation.createRoom-2.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:5a4d575a095aee3ac2faf19c484833383a565eb221c81d1237c4db9d1639195c
-size 168409
+oid sha256:d26b867ddd17121d63a86fc7c2fc5d168138e777b77e20993e895a3205ea9a60
+size 167607
diff --git a/UITests/Sources/__Snapshots__/Application/pseudo-iPad-9th-generation.createRoom-3.png b/UITests/Sources/__Snapshots__/Application/pseudo-iPad-9th-generation.createRoom-3.png
index 4efbb41d09..a57071a22b 100644
--- a/UITests/Sources/__Snapshots__/Application/pseudo-iPad-9th-generation.createRoom-3.png
+++ b/UITests/Sources/__Snapshots__/Application/pseudo-iPad-9th-generation.createRoom-3.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:980a38d3329e437ae0756d3e05d552786d9d4b05276dfe20a316e99348af812a
-size 241512
+oid sha256:997cf7df906c4f1181919ccd5c3ddb67fa9ecf8763c322ff86b52b9a30045afb
+size 243229
diff --git a/UITests/Sources/__Snapshots__/Application/pseudo-iPhone-14.createRoom-0.png b/UITests/Sources/__Snapshots__/Application/pseudo-iPhone-14.createRoom-0.png
index 17514d26b2..ff0608dde2 100644
--- a/UITests/Sources/__Snapshots__/Application/pseudo-iPhone-14.createRoom-0.png
+++ b/UITests/Sources/__Snapshots__/Application/pseudo-iPhone-14.createRoom-0.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:cb1e31c93ef5a063d75df8d23a687e31e40078b675f3e199ff7375069068680f
-size 238800
+oid sha256:a9836261fe75bd8ec31d77d048c91946c96bc3b3bd8ddbe13ec3b90624e39169
+size 237172
diff --git a/UITests/Sources/__Snapshots__/Application/pseudo-iPhone-14.createRoom-1.png b/UITests/Sources/__Snapshots__/Application/pseudo-iPhone-14.createRoom-1.png
index 0dc825b66d..0104efffd4 100644
--- a/UITests/Sources/__Snapshots__/Application/pseudo-iPhone-14.createRoom-1.png
+++ b/UITests/Sources/__Snapshots__/Application/pseudo-iPhone-14.createRoom-1.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:9c68ff019a95bbc7dd07060139eca4bfc6029984def7ca2246ba2e95b647935c
-size 220005
+oid sha256:e9174f0db28596938b88829091fd9c90d16c1de8f14f4900d558fe162a054c62
+size 217019
diff --git a/UITests/Sources/__Snapshots__/Application/pseudo-iPhone-14.createRoom-2.png b/UITests/Sources/__Snapshots__/Application/pseudo-iPhone-14.createRoom-2.png
index c477f8bfc2..36c757a77f 100644
--- a/UITests/Sources/__Snapshots__/Application/pseudo-iPhone-14.createRoom-2.png
+++ b/UITests/Sources/__Snapshots__/Application/pseudo-iPhone-14.createRoom-2.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:d40f1d024aa5d6a045b2476b25d76466b15f1279a7d02d749cf7b8d2cafc6149
-size 199083
+oid sha256:fe162b46781700a0d83e0d2e1eb8fce4eb7cf5018530ba6b178d423dab95da4a
+size 192802
diff --git a/UITests/Sources/__Snapshots__/Application/pseudo-iPhone-14.createRoom-3.png b/UITests/Sources/__Snapshots__/Application/pseudo-iPhone-14.createRoom-3.png
deleted file mode 100644
index 3b189265d7..0000000000
--- a/UITests/Sources/__Snapshots__/Application/pseudo-iPhone-14.createRoom-3.png
+++ /dev/null
@@ -1,3 +0,0 @@
-version https://git-lfs.github.com/spec/v1
-oid sha256:df90685e30f3f87791154ba9af26fead49fe05336c7e19dad73f290ab9c07c37
-size 221890