Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Danger rule for LFS #172

Closed
pixlwave opened this issue Sep 6, 2022 · 1 comment
Closed

Add a Danger rule for LFS #172

pixlwave opened this issue Sep 6, 2022 · 1 comment
Assignees
@pixlwave
Labels
A-DevX Anything that can improve the DevX Z-BBQ-Alpha Required for ElementX - BBQ - Alpha

Comments

@pixlwave
Copy link
Member

pixlwave commented Sep 6, 2022 •
edited by VolkerJunginger
Loading

Ideally we should have a rule to detect when a files gets committed to UITests/Sources/__SNAPSHOTS__/Application as a regular file instead of an LFS reference.

This will likely mean comparing the added/changed files path against git lfs ls-files from what I can tell.
@pixlwave pixlwave added A-DevX Anything that can improve the DevX Z-BBQ-Alpha Required for ElementX - BBQ - Alpha labels Sep 6, 2022
@pixlwave
Copy link
Member Author

pixlwave commented Sep 22, 2022 •
edited
Loading

Closed by #203 (although as a workflow rather than a Danger rule)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixlwave pixlwave

Labels
A-DevX Anything that can improve the DevX Z-BBQ-Alpha Required for ElementX - BBQ - Alpha
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixlwave