-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accepting a room invite does not reliably show history since the invite was sent. #2024
Comments
sometimes the history is visible the first time you view the room, but then vanishes or vanishes the 2nd time you view the room. |
@stefanceriu Hi, do you know if this issue is observed on EX-Android too? Don't you think it is a Rust sdk issue? What would be the complexity to fix it? |
It's already marked as |
I rested this today and am no longer able to reproduce it. Sent over 100 messages before accepting the invite and they all were rendered properly
|
I just saw this happen first hand on Amandine's account (albeit on build 628) |
i would assume this is some nasty race on when you subscribe to the room v. when you backpaginate the room or something |
this is a dup of #1240 |
I think this is related to matrix-org/matrix-rust-sdk#3622. |
It does seem related, in a version without the fix for matrix-org/matrix-rust-sdk#3622 I was able to reproduce something similar by creating the room in EXA, then inviting the user and immediately killing the internet connection of my device, accepting the invite in another client and then restoring internet connection in my device so the messages are sent. I got this on EW: And this on EXA in the other client: EW displays the first 3 messages sent while the app was offline as UTDs, because of the linked error in the Rust SDK, and the 2 new ones are fine (although the replied to messages are UTDs too). EXA displayed the 5 messages as UTDs the first time I opened the room, then only the new 3 ones, which seems quite similar to what is discussed here (the first 2 UTDs are removed from the TL forever). However I haven't been able to reproduce it again 🫤 . |
I moved the occurence to |
i got this badly a few days ago. from memory:
see rageshake. |
have marked O-Occasional as in practice i think i've seen this on almost every invite i've received (but presumably others don't)? |
Just did test this on latest nightly Android (inviting) > iOS (accepting). Could see all the 15 messages after accepting the inviting. |
Was able to reproduce this just now Web to iOS:
|
Right. that sounds like the one. I also got it just now on a fresh login; i viewed a room which was fine at first, went back to room list, went in again, and all the history before the most recent join suddenly vanished. |
Turns out this has nothing to do with invites and occurs on any room that has more than a single sync chunk's worth of messages and that you've scrolled all the way back to the start. It can be reproduced by scrolling back to the start in any room, closing it and then opening it again. I've tracked it down to here where after we've reached the start of a room, I think this is made worse by the timeline resets the SSS is doing more frequently, but it still happens without seeing a reset on the screen too (I haven't checked with a SS proxy). |
Thanks for that last comment @pixlwave, that highlighted the issue to me, will write a patch. |
Steps to reproduce
Outcome
What did you expect?
history sent since they were invited should be visible.
What happened instead?
flakiness
Your phone model
No response
Operating system version
No response
Application version
427
Homeserver
No response
Will you send logs?
No
The text was updated successfully, but these errors were encountered: