Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't open rooms with slashes in the ID #451

Closed
tulir opened this issue Aug 15, 2021 · 2 comments · Fixed by #939
Closed

Can't open rooms with slashes in the ID #451

tulir opened this issue Aug 15, 2021 · 2 comments · Fixed by #939
Assignees
@MidhunSureshR
Labels
bug Something isn't working

Comments

@tulir
Copy link

tulir commented Aug 15, 2021 •
edited
Loading

To Reproduce

  1. Join a room whose room ID contains a slash (/), e.g. #test:maunium.net (room ID !test/v7 🐈️:maunium.net)
  2. Try to open the room in Hydrogen
  3. Hydrogen says "You are not currently in !test. Want to join it?"

Expected behavior
The room is opened and the user can send messages

Screenshots
image

Smartphone (please complete the following information):

  • Device: Nokia 8.3 5G
  • OS: Android 11
  • Browser: Firefox 91.0.0-beta.6
  • Version: 0.2.5
@bwindels bwindels added the bug Something isn't working label Aug 16, 2021
@bwindels
Copy link
Contributor

I imagine it does work when your encodeURIComponent the room id?

@tulir
Copy link
Author

tulir commented Aug 16, 2021

Didn't think to try that earlier since I had installed Hydrogen as a PWA, but looks like it doesn't work:

image

@MidhunSureshR MidhunSureshR self-assigned this Nov 24, 2022
@MidhunSureshR MidhunSureshR mentioned this issue Nov 25, 2022
Merged
@psrpinto psrpinto mentioned this issue Dec 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MidhunSureshR MidhunSureshR

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix '/' in room-id or mxid breaking navigation element-hq/hydrogen-web
3 participants
@bwindels @tulir @MidhunSureshR