Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synapse does not tell the clients when it runs out of OTKs #10484

Closed
matrixbot opened this issue Dec 18, 2023 · 2 comments
Closed

Synapse does not tell the clients when it runs out of OTKs #10484

matrixbot opened this issue Dec 18, 2023 · 2 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 18, 2023

This issue has been migrated from #10484.


Following discussion in #10479 (and especially matrix-org/synapse#10479 (comment)), I've checked the sync response when Synapse does not have OTK (one time key) anymore. So when the number of OTK is changing from N to 0.

Instead of receiving

"device_one_time_keys_count":{"signed_curve25519":0}

The client receives

"device_one_time_keys_count":{}

and so the client cannot distinguish "no change" and "no OTK left", and do not upload new OTK, which at the end breaks decryption of some messages.

Server version: 1.38.0 commit 12c92ee

@matrixbot matrixbot changed the title Dummy issue Synapse does not tell the clients when it runs out of OTKs Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
@kegsay
Copy link
Contributor

kegsay commented Jan 4, 2024

Empirically this does work and is tested in sliding sync as of matrix-org/sliding-sync#390

@richvdh
Copy link
Member

richvdh commented Jul 26, 2024

It's unclear what remains to be done here. Seems like the implementation is compliant with the spec.

@richvdh richvdh closed this as completed Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants