Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use StrCollection in more places #14809

Open
matrixbot opened this issue Dec 20, 2023 · 0 comments
Open

Use StrCollection in more places #14809

matrixbot opened this issue Dec 20, 2023 · 0 comments
Labels
O-Occasional S-Minor T-Task Z-Cleanup

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 20, 2023 •
edited
Loading

This issue has been migrated from #14809.

Using a Sequence[str] or Collection[str] is bad since a str also fits those and you usually want this to refer to a Set[str], List[str], Tuple[str, ...], etc.

In #14716 @reivilibre added a StrCollection type which we can re-use for this.

This has bit us a few times in the past but I'm failing to find references at the moment.

It would be good to audit Sequence[str] and Collection[str] and see if any of those should be updated.
@matrixbot matrixbot changed the title Dummy issue Use StrCollection in more places Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-Occasional S-Minor T-Task Z-Cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matrixbot