New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize MSC4041 support (Retry-After header) #16944

Closed

clokep opened this issue Feb 20, 2024 · 0 comments · Fixed by #16947

Contributor

clokep commented Feb 20, 2024

MSC4041 has passed FCP and can be stabilized in Synapse.

See matrix-org/synapse#16136 for the initial implementation.

The steps to do this are:

Remove the changes in synapse/config/experimental.py to set LimitExceededError.include_retry_after_header.
Remove the LimitExceededError.include_retry_after_header flag (and default to it being enabled always).
Update the tests at tests/api/test_errors.py and tests/rest/client/test_login.py.

That should be all that's necessary, but some other tests could break due to this. It should be a fully backwards compatible change.

The text was updated successfully, but these errors were encountered:

clokep mentioned this issue

Stabilize support for Retry-After header (MSC4014) #16947

Merged

3 tasks

anoadragon453 closed this as completed in #16947

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment