Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing the title of an event reschedules it to today's next whole hour #453

Closed
cassidyjames opened this issue Oct 29, 2019 · 1 comment · Fixed by #482
Closed

Editing the title of an event reschedules it to today's next whole hour #453

cassidyjames opened this issue Oct 29, 2019 · 1 comment · Fixed by #482
Labels
Priority: High To be addressed after any critical issues
Milestone

Comments

@cassidyjames
Copy link
Contributor

cassidyjames commented Oct 29, 2019

Looks to be a regression from #209. Might require pressing Enter in the event name when editing, I haven't fully tracked down when it happens but it's fairly reproducible.

@Thalexander
Copy link
Collaborator

Thalexander commented Nov 17, 2019

ParserEn (line 185) and ParserDe (line 150) both work by assuming the time as being today's next whole hour and the modify that based on the text, the parsing runs on enter in the event title and so causes this issue. This does not occur repeatedly in the same panel though as parsing only happens once, so changing the event name again without saving and then pressing enter will just save the event rather than re-parsing. Unrelated to #209, although it uses the previous logic for the next whole hour, we may want to change that to match the new behaviour.

It will reset the to and from dates and times, the all day toggle, and the location. It will not however change the participants because that doesn't work even if parsed, if parsed it just adds the names to the text entry box in the guests panel but doesn't add them.

@cassidyjames cassidyjames added the Priority: Medium Should be addressed when time allows label Nov 19, 2019
@cassidyjames cassidyjames mentioned this issue Nov 25, 2019
6 tasks
@cassidyjames cassidyjames pinned this issue Nov 25, 2019
@cassidyjames cassidyjames added Priority: High To be addressed after any critical issues and removed Priority: Medium Should be addressed when time allows labels Nov 25, 2019
@danirabbit danirabbit added this to the 5.0.2 milestone Nov 25, 2019
@mcclurgm mcclurgm unpinned this issue Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High To be addressed after any critical issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants