Fix icons clipping when bouncing

[leolost2605]

Fixes #275 without some issues introduced in #303 like a gap between maximized window and dock when set to never hide or offset context menus.

Requires elementary/gala#2108

[teamcons]

thank you :)

[zeebok]

I installed the gala update so the dock isn't below the screen edge but the clipping is still happening

Edit: This happens in both session types

[leolost2605]

I installed the gala update so the dock isn't below the screen edge but the clipping is still happening

Edit: This happens in both session types

Hmm that's strange I just tested again and the issue is fixed for me when using gala main and this branch on both X and wayland.
Do you have some logs that might help?
Or do you have some custom theming applied? This includes some CSS changes that are required to apply 🤷

[lenemter]

So, this PR hardcodes bottom margin... but we probably should make it editable by custom css because of #304 (comment). You can probably make a some widget on the bottom and set its height to 9 by default in the Application.css, but I'm not sure if it will work.

[teamcons]

So, this PR hardcodes bottom margin... but we probably should make it editable by custom css because of #304 (comment). You can probably make a some widget on the bottom and set its height to 9 by default in the Application.css, but I'm not sure if it will work.

Bottom padding propery for the dock element, i would guess.

can confirm clipping still happening with this branch

[leolost2605]

So, this PR hardcodes bottom margin... but we probably should make it editable by custom css because of #304 (comment). You can probably make a some widget on the bottom and set its height to 9 by default in the Application.css, but I'm not sure if it will work.

Bottom margin has always been hardcoded (in the CSS), this PR only uses that value to get some calculations right. I think we should change that in a different PR.

[leolost2605]

can confirm clipping still happening with this branch

That is so strange :(
Is there anyone for whom this branch fixes clipping?
Also are you sure you installed the updated CSS? I'm not sure but I had some issues with it not being updated in the past and a ninja clean followed by a ninja install would fix that 🤷

[leolost2605]

So, this PR hardcodes bottom margin... but we probably should make it editable by custom css because of #304 (comment). You can probably make a some widget on the bottom and set its height to 9 by default in the Application.css, but I'm not sure if it will work.

Bottom margin has always been hardcoded (in the CSS), this PR only uses that value to get some calculations right. I think we should change that in a different PR.

Ah nvm I think I missed your point (with CSS being changeable and the constant not), I'll look into it

[zeebok]

can confirm clipping still happening with this branch

That is so strange :( Is there anyone for whom this branch fixes clipping? Also are you sure you installed the updated CSS? I'm not sure but I had some issues with it not being updated in the past and a ninja clean followed by a ninja install would fix that 🤷

Alright I pulled latest master since the referred gala PR was merged, did a clean, and an install, and..... it mostly works! I think the margin is just not quite high enough. Most icons work but Photos has the tip of the tilted photo at the top of the icon cut off.

[danirabbit]

Superseded by #328