Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't depend on LibPlank #2292

Closed
danirabbit opened this issue Aug 19, 2023 · 2 comments · Fixed by #2356
Closed

Don't depend on LibPlank #2292

danirabbit opened this issue Aug 19, 2023 · 2 comments · Fixed by #2356

Comments

@danirabbit
Copy link
Member

danirabbit commented Aug 19, 2023

What Happened?

We currently depend on LibPlank for the PoofWindow, but (hopefully in OS 8) we'll be leaving Plank behind for a new Wayland-compatible dock

Steps to Reproduce

Try to build without LibPlank I guess 😅 Relevant code is in BookmarkRow.vala

Expected Behavior

We should either:
a. Move this PoofWindow stuff into Granite, if we intend to make this a pattern that all apps should use for removing draggable items
b. Move it into Files if this is a Files-specific thing
c. Just not have this at all

OS Version

7.x (Horus)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

@danirabbit danirabbit added this to OS 8 Aug 19, 2023
@danirabbit danirabbit moved this to Needs Discussion in OS 8 Aug 19, 2023
@jeremypw
Copy link
Collaborator

I think the only other thing using it is Plank itself. I think we might as well lose it from Files if it is not intended to make it a general pattern for removing sidebar items in all other apps.

@jeremypw
Copy link
Collaborator

I guess we can lose dragging items out of the sidebar altogether not just the animation. Code and settings plugs do not implement that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants