WorkspaceManager: Exclude a window that's about to be removed from count #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2145
Though probably not the same as #2145 (I've seen this one before the gesturepropertytransition got merged and the system version says stable) this probably also fixes #2159
We have to do this because a window that's about to be removed still appears in the list returned by Meta.Workspace.list_windows when window_removed is emitted (at least if it's just moved and not closed).
Also fixes an inconsistency, where when in the multitasking view, a workspace would be immediately removed when the last window on it was closed but not when it was moved to another one.