Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use file basename instead of uri for the default audio object title. #710

Merged
merged 1 commit into from
May 21, 2022

Conversation

vjr
Copy link
Member

@vjr vjr commented May 21, 2022

It appears that if the audio file doesn't have a title tag then Music uses the ugly file URI by default. This PR uses the prettier file basename if available otherwise falls back to the URI anyway.

See the track title on both panes - playlist on the left and above the progress bar on the right.

Before:

image

After:

image

@vjr vjr requested a review from a team May 21, 2022 22:04
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better default, thanks!

@danirabbit danirabbit merged commit 97a437e into main May 21, 2022
@danirabbit danirabbit deleted the pretty-title branch May 21, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants