No icon on wingpanel after updated to 7.0.0

[bobby285271]

What Happened?

As shown in the screenshot, wingpanel (the top panel) is missing a bluetooth icon:

Steps to Reproduce

1. Boot to Pantheon updates 2023-06-28 NixOS/nixpkgs#240261
2. See the wingpanel?

Expected Behavior

Icon appears.

OS Version

Other Linux

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

[bobby285271]

I am looking at #196 since this is probably the only icon-related change in this bump (edit: and reverting it fixes the issue)

In NixOS/nixpkgs#240261 I am also testing a wingpanel-indicator-notifications bump, which has very similar change, but it looks like the wingpanel-indicator-notifications icon still works fine.

[bobby285271]

I found the icon actually appears fine in greeter/lock screen, it is just missing in a desktop session 🤔

I also managed to reproduce this on a fresh VM (by forcing the indicator to be visible).

[tintou]

@danirabbit I believe that we are missing Gtk.IconTheme.get_default ().add_resource_path ("/org/elementary/wingpanel/icons") at some place.

Also, <gresource prefix="org/elementary/wingpanel/icons"> is missing the leading slash

[tintou]

I would personally change it for /io/elementary/wingpanel/bluetooth/icons to avoid prefix clash

[danirabbit]

Hm I'm not able to reproduce this.

@tintou It's namespaced that way intentionally so that Gtk.Application loads the resource into the icon path automatically and don't need to manually add it

[tintou]

Ah true, we still need the leading slash though

[jeremypw]

Perhaps the automatic loading of the resource to the icon theme is not happening on NixOS for some reason. This issue does not occur on elementary.

[bobby285271]

Yeah from my testing a explicit add_resource_path does fixes the issue for me, i.e.

diff --git a/src/Widgets/DisplayWidget.vala b/src/Widgets/DisplayWidget.vala
index daded09..bb7ce5e 100644
--- a/src/Widgets/DisplayWidget.vala
+++ b/src/Widgets/DisplayWidget.vala
@@ -25,6 +25,9 @@ public class BluetoothIndicator.Widgets.DisplayWidget : Gtk.Spinner {
     }
 
     construct {
+        weak Gtk.IconTheme default_theme = Gtk.IconTheme.get_default ();
+        default_theme.add_resource_path ("/org/elementary/wingpanel/icons");
+
         var provider = new Gtk.CssProvider ();
         provider.load_from_resource ("io/elementary/wingpanel/bluetooth/indicator.css");

And from testing it sounds like doing this also helps other indicators, i.e. after adding this patch I found elementary/wingpanel-indicator-nightlight#101 (comment) fixed too.

/sos @jtojnar 🙃 Any chance our https://github.com/NixOS/nixpkgs/blob/master/pkgs/desktops/pantheon/desktop/wingpanel/wrapper.nix are breaking automatic loading resource here?

[tintou]

@danirabbit I believe that the autoloading of resources is done too early in the process when the indicators are not already loaded, and as they are plugins it might be the case, I propose to use some explicit loading to be on the safe side even in elementary

[danirabbit]

Sounds good, I'll make a branch!