Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert loadProps.gradle to Kotlin script #127

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

sschuberth
Copy link
Contributor

@sschuberth sschuberth commented Jan 2, 2023

Ready for review

This is for consistency with all the other Gradle files.

@sgammon
Copy link
Member

sgammon commented Jan 2, 2023

@sschuberth hey, thank you so much for this!

@sgammon sgammon added enhancement New feature or request tools Issues and PRs related to tooling labels Jan 2, 2023
@sschuberth
Copy link
Contributor Author

@sgammon can you tell whether the failures are due to my change, or is something else going on?

@sgammon
Copy link
Member

sgammon commented Jan 2, 2023

@sschuberth i pulled down and tested locally, it looks like CI on v3 is just out of date. release/alpha2 and feat/js-runtime-v3 are where development is happening right now.

cherry-picking to release/alpha2 worked fine, i may re-target the PR to that branch and merge there instead.

all the tests passed of course, it looks like your change is fine.

@sgammon sgammon changed the base branch from v3 to feat/js-runtime-v3 January 2, 2023 20:55
This is for consistency with all the other Gradle files.
@sgammon
Copy link
Member

sgammon commented Jan 2, 2023

@sschuberth now it's complaining because build secrets aren't making it in -- this is the first contribution btw outside of the core team! so i may need to tweak the workflows to allow the secrets, because they aren't really all that sensitive. it's just code coverage reporting, etc.

the tests all pass locally, so i think we can safely ignore CI and merge. thank you so much for your contribution, even though it's small, it means an enormous amount to us, since it's the first one! 🎉

@sgammon sgammon merged commit d4ea13f into elide-dev:feat/js-runtime-v3 Jan 2, 2023
@sgammon
Copy link
Member

sgammon commented Jan 2, 2023

new check run on feat/js-runtime-v3 looking fine.

@sschuberth
Copy link
Contributor Author

even though it's small, it means an enormous amount to us, since it's the first one! 🎉

It was just a test balloon from my side 😉 This project sounds really cool, and if it turns out to be of use in one of my projects, I hope to be able to make more contributions!

@sschuberth sschuberth deleted the loadProps2kts branch January 2, 2023 21:04
@sgammon
Copy link
Member

sgammon commented Jan 2, 2023

hey, test balloon or not, we'll take it @sschuberth! lol.

i see you're a Kotlin fan. feel free to join us on Kotlin Slack in #framework-elide if you have any suggestions or ideas you'd like to share. 💯

@sgammon sgammon mentioned this pull request Jan 14, 2023
21 tasks
sgammon added a commit that referenced this pull request Jan 14, 2023
![Ready for
review](https://badgen.net/badge/Status/Ready%20for%20review/green)<!--
PR-BADGE: PLEASE DO NOT REMOVE THIS COMMENT -->

This changeset begins major work on the `alpha2` release of the Elide
suite of libraries. See below for ongoing changelog.

## PR Tree

- Consituent PRs:
  - #116
  - #127

## Changelog

- [x] JavaScript VM Improvements
  - [x] Ability to retrieve `state`, `context`, `path`
  - [x] Support for Web Streams API
  - [x] Entrypoint support for streaming/chunked render responses
  - [x] Pre-warmed JS VM
  - [x] Static initialization of JS VM
- [x] Server Lifecycle
  - [x] `INIT` hooks
  - [x] `WARMUP` hooks
- [x] SSR / SSG Support
  - [x] Expose streaming render to VM
  - [x] Dispatch streaming callback with response chunks
  - [x] Streamed responses from outer serving layer
  - [x] Native SSR support
  - [x] Run SSG compile from Gradle
- [x] Cleanup & Refactor
  - [x] Combine SSR code into new `ssr` KMP package
  - [x] Combine/drop separate `rpc` packages
  - [x] Refresh all Docker bases
  - [x] Issue JDK 19 images
  - [x] Transition CI to multi-JVM testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tools Issues and PRs related to tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants