-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert loadProps.gradle
to Kotlin script
#127
Conversation
5973742
to
2ed71bc
Compare
@sschuberth hey, thank you so much for this! |
@sgammon can you tell whether the failures are due to my change, or is something else going on? |
@sschuberth i pulled down and tested locally, it looks like CI on cherry-picking to all the tests passed of course, it looks like your change is fine. |
This is for consistency with all the other Gradle files.
@sschuberth now it's complaining because build secrets aren't making it in -- this is the first contribution btw outside of the core team! so i may need to tweak the workflows to allow the secrets, because they aren't really all that sensitive. it's just code coverage reporting, etc. the tests all pass locally, so i think we can safely ignore CI and merge. thank you so much for your contribution, even though it's small, it means an enormous amount to us, since it's the first one! 🎉 |
new check run on |
It was just a test balloon from my side 😉 This project sounds really cool, and if it turns out to be of use in one of my projects, I hope to be able to make more contributions! |
hey, test balloon or not, we'll take it @sschuberth! lol. i see you're a Kotlin fan. feel free to join us on Kotlin Slack in |
![Ready for review](https://badgen.net/badge/Status/Ready%20for%20review/green)<!-- PR-BADGE: PLEASE DO NOT REMOVE THIS COMMENT --> This changeset begins major work on the `alpha2` release of the Elide suite of libraries. See below for ongoing changelog. ## PR Tree - Consituent PRs: - #116 - #127 ## Changelog - [x] JavaScript VM Improvements - [x] Ability to retrieve `state`, `context`, `path` - [x] Support for Web Streams API - [x] Entrypoint support for streaming/chunked render responses - [x] Pre-warmed JS VM - [x] Static initialization of JS VM - [x] Server Lifecycle - [x] `INIT` hooks - [x] `WARMUP` hooks - [x] SSR / SSG Support - [x] Expose streaming render to VM - [x] Dispatch streaming callback with response chunks - [x] Streamed responses from outer serving layer - [x] Native SSR support - [x] Run SSG compile from Gradle - [x] Cleanup & Refactor - [x] Combine SSR code into new `ssr` KMP package - [x] Combine/drop separate `rpc` packages - [x] Refresh all Docker bases - [x] Issue JDK 19 images - [x] Transition CI to multi-JVM testing
This is for consistency with all the other Gradle files.