Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

math extension: issue with undefined targets #143

Open
pkra opened this issue Jan 12, 2016 · 1 comment
Open

math extension: issue with undefined targets #143

pkra opened this issue Jan 12, 2016 · 1 comment

Comments

@pkra
Copy link
Contributor

pkra commented Jan 12, 2016

We ran into what looks like a bug in the math extension. I couldn't quite identify the corresponding part in the XML but it seems the issue is the following.

In https://github.com/elifesciences/lens/blob/master/extensions/math/math_converter.js#L671-L676, should referencedMath[targetNode.id] = true; be inside the preceding if (targetNode) { ... }?

@pkra
Copy link
Contributor Author

pkra commented Jan 12, 2016

To add some background. This was caused by a JATS file with appendices and references into theorem environments in the appendices. Lens drops the appendices (I think that's intentional, correct?) and thus there is no target for the reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant