Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when conversion region wasn't studied #66

Closed
rhdolin opened this issue May 17, 2021 · 1 comment · Fixed by #69
Closed

Error when conversion region wasn't studied #66

rhdolin opened this issue May 17, 2021 · 1 comment · Fixed by #69

Comments

@rhdolin
Copy link
Contributor

rhdolin commented May 17, 2021

Prerequisites

Please answer the following questions for yourself before submitting an issue.

  • [x ] I am running the latest version
  • [x ] I checked the documentation and found no answer
  • [x ] I checked to make sure that this issue has not already been filed

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Test case is based on a targeted genome study. (vcf_filename='HG00403A.vcf.gz', has_tabix='True', ref_build='GRCh37', conv_region_filename='HG00403A_convert.bed', region_studied_filename='HG00403A_studied.bed') (files are on google drive in vcf2fhir/test_cases folder)

Expected Behavior

When the requested conversion region hasn't been studied, we are generating a non-conformant diagnostic report. We should decide what we want in this situation - for instance, we probably want to include a regionStudied observation that somehow indicates that the intersection of convert and studied is null.

@rhdolin
Copy link
Contributor Author

rhdolin commented May 26, 2021

Suggested resolution - where intersection is null, include a region-studied observation, where ranges-examined's dataAbsentReason is set to 'not-performed'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant