Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for defn? #474

Open
anildigital opened this issue May 5, 2021 · 3 comments
Open

Support for defn? #474

anildigital opened this issue May 5, 2021 · 3 comments
Labels
enhancement good first issue New to contributing to emacs-related F/OSS? This may be for you.

Comments

@anildigital
Copy link
Contributor

Elixir have added new keyword named defn for defining numerical definitions

More at https://dashbit.co/blog/nx-numerical-elixir-is-now-publicly-available

@jsmestad
Copy link
Contributor

jsmestad commented May 5, 2021

Am I correct that it is not in the core language but provided by Nx?

@wingyplus
Copy link
Contributor

Am I correct that it is not in the core language but provided by Nx?

Yes it is

@victorolinasc victorolinasc added enhancement good first issue New to contributing to emacs-related F/OSS? This may be for you. labels Jun 12, 2023
@victorolinasc
Copy link
Contributor

My opinion is that we can add defn and defnp only because elixir-nx is a core project maintained by people that are close to the core language. I don't think we will, though, add all possible macros there are in the language. We "should" be able to add a customization for that so that people may choose to add other defsomething macros. Not sure how to achieve that now as it should be a compile-time configuration as we are regex-driven in this mode (and all modes pre-tree-sitter).

PRs would be appreciated! It is an easy first fix I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue New to contributing to emacs-related F/OSS? This may be for you.
Projects
None yet
Development

No branches or pull requests

4 participants