Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non standard expandMacro request #11

Closed
rodrigues opened this issue Jan 6, 2019 · 2 comments · Fixed by #498
Closed

Non standard expandMacro request #11

rodrigues opened this issue Jan 6, 2019 · 2 comments · Fixed by #498

Comments

@rodrigues
Copy link
Contributor

Comparing this fork with Jake's master, I've found this: JakeBecker/elixir-ls@643bb31

Is this still conformant to the language server protocol?

In the specification, if you search for interface ServerCapabilities, the allowed keys seems to be a very strict set, I'm not sure if adding macro expansion is valid.

Maybe that's the case for a code action instead?

Thanks!

@axelson
Copy link
Member

axelson commented Jan 7, 2019

It's still intending to be conformant to the language server protocol. Do you know of a way to register a new custom capability from the server?

@rodrigues
Copy link
Contributor Author

@axelson it seems to me that code actions are the way to go

@lukaszsamson lukaszsamson changed the title LSP compatibility issue? Non standard expandMacro request Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants