Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do<enter> becomes defoverridable() when creating new functions #610

Closed
2 tasks done
fkumro opened this issue Oct 9, 2021 · 10 comments
Closed
2 tasks done

do<enter> becomes defoverridable() when creating new functions #610

fkumro opened this issue Oct 9, 2021 · 10 comments

Comments

@fkumro
Copy link

fkumro commented Oct 9, 2021

Environment

  • Elixir & Erlang versions (elixir --version):
Erlang/OTP 24 [erts-12.0.3] [source] [64-bit] [smp:24:24] [ds:24:24:10] [async-threads:1] [jit]

Elixir 1.12.2 (compiled with Erlang/OTP 24)
  • Operating system:

Pop!_OS 21.04

  • Editor or IDE name (e.g. Emacs/VSCode):

VSCodium

  • Editor Plugin/LSP Client name:

elixir-lsp/vscode-elixir-ls

Troubleshooting

  • Restart your editor (which will restart ElixirLS) sometimes fixes issues
  • Stop your editor, remove the entire .elixir_ls directory, then restart your editor

Logs

  1. Create a new Mix project with mix new empty, then open that project with VS Code and open an Elixir file. Is your issue reproducible on the empty project? If not, please publish a repo on Github that does reproduce it.

Yes, mix new empty will allow you to recreate the issue.


Issue

When creating a new function, autocomplete changes do<enter> to defoverridable().

def test do

becomes

def test defoverridable()
@hassanshaikley
Copy link

I am not able to recreate this. Unless I literally have an empty file and type in:

do<enter> but I don't see why that is an important behavior?

def x do<enter> behaves correctly.

Is there something I am missing?

@zorn
Copy link

zorn commented Oct 13, 2021

I have seen this behavior myself but can not reproduce it right now. Will keep my eye out for what might trigger it.

@axelson
Copy link
Member

axelson commented Oct 15, 2021

👋 @fkumro @zorn Can you check that you're on the latest version of ElixirLS? That should be fixed in #593 which was released in 0.8.1. I was just able to test it in my lsp-mode setup:

Screen Shot 2021-10-14 at 9 37 28 PM

@fkumro
Copy link
Author

fkumro commented Oct 15, 2021

👋 @axelson I installed the extension from the Open VSX registry which has the current version at 0.8.0

https://open-vsx.org/extension/elixir-lsp/elixir-ls

@zorn
Copy link

zorn commented Oct 15, 2021

My current version is v0.8.1 and as I said, I can not currently recreate it, but have experienced it before. Thanks for the followup. I'm going to jump off the thread unless it pops up again.

@axelson
Copy link
Member

axelson commented Oct 16, 2021

@fkumro Okay, it looks like I missed the Open VSX registry when I released 0.8.1. So I just published 0.8.1. Can you upgrade and try again please?

@kinson
Copy link

kinson commented Oct 16, 2021

Thanks @axelson, upgrading to v0.8.1 seems to have fixed this issue for me 🎉

@axelson
Copy link
Member

axelson commented Oct 16, 2021

@kinson Great! I'm going to go ahead and close it. @fkumro if you're still encountering it let me know and we can re-open it or file a new issue as appropriate. And thanks @hassanshaikley for taking a look at this 👍

@axelson axelson closed this as completed Oct 16, 2021
@fkumro
Copy link
Author

fkumro commented Oct 16, 2021

@axelson Updated and the issue is solved, thank you 🙇‍♂️

@axelson
Copy link
Member

axelson commented Oct 16, 2021

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants