-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load all modules after first build #227
Conversation
43420e7
to
cadd374
Compare
initialize(server) | ||
|
||
# Upon first vist, server complies and loads all umbrella applications and modules | ||
Process.sleep(1_500) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the server process is handling a message, then simply calling :sys.get_state
will make the calling process block until the server process is ready. If the server is waiting for an async message from other process you can call :sys.get_state
in a loop with short sleeps until the state returned indicates that async task is completed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. I'll will try to update test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated, please check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks! ❤️
elixir-lsp/vscode-elixir-ls#93 #237 #227 #241 Removed known issue due to fix in #241
* WorkspaceSymbols index after successful build Previously WorkspaceSymbols depended on a side-effect of running Dialyzer: #110 (comment) Now that the Build step loads all modules (added in #227) we need to change the WorkspaceSymbols index to be rebuilt after a successful compile. * Fix tests Allow WorkspaceSymbol to have it's own instance of the GenServer for the test by being parameterized by the server's registered name * Give Server some more time to respond This is probably necessary now because workspace symbols is running earlier * Bump up the timeout
Closes #209
The test contains sleep as the build is async. I'm not sure about sleep duration. Let me know if there is a better way to test this