Fixes and improvements around text synchronisation #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes some issues when certain sequence of notifications would create nil entries in source_files map
fix some consistency issues: dirty? flag not updated when file modified outside (no didSave) rebuild not triggered when opened dirty file modified outside
based on https://github.com/microsoft/vscode-languageserver-node fixes a few edge cases when dealing with invalid ranges
lukaszsamson
commented
Nov 22, 2020
lukaszsamson
commented
Nov 22, 2020
axelson
approved these changes
Nov 24, 2020
| |> (&binary_part( | ||
| &1, | ||
| 0, | ||
| min(start_character * 2, byte_size(&1)) |
There was a problem hiding this comment.
Can you explain why min is needed here? And why min/max is needed for the other similar call later in the file. I'm thinking that it would be better to extract a helper function since this function is already quite large and indexing into a utf8 string as if it was utf16 is a nice well-contained problem. I took a stab at doing it myself, but I wasn't clear on the min/max constraints so I couldn't integrate those well.
There was a problem hiding this comment.
Without that it crashes with ArgumentError when range is invalid (starts at negative, starts over length or takes more chars than are in binary). It shouldn't happen normally but it does when client looses synch with the server, e.g. in #277
The previous implementation did not have any bugs (that I saw), but I did find it more difficult to read and understand. I expect performance to be comparable. For more comprehensive testing I have added StreamData which adds property-based testing. We can probably use that in other portions of the code base as well.
Co-authored-by: Jason Axelson <axelson@users.noreply.github.com>
Refactor implementation of SourceFile.lines_with_endings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several spec compliance issues and consistency bugs.
all requests involving not tracked URIs will now return InvalidParam error code
didOpen/didCloseetc. notifications are now rejectedadds test coverage
nilentry could be createddidChangeWatchedFileshandlerdirty?flag not removedSourceFile\r\nand\rnot being preserved (spec requires preservation)SourceFile.full_range(Comprehensive approach to utf-16 positions #244)Fixes #12