Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link stack traces to relevant files #152

Merged
merged 1 commit into from
Nov 15, 2020
Merged

Conversation

jayjun
Copy link
Contributor

@jayjun jayjun commented Nov 10, 2020

This pull request uses the new VS Code Terminal Link Provider to turn locations in stack traces into links that jump to the relevant file/line.

For identically named files across workspace folders, a Quick Pick dropdown is shown for selection.

Fixes #90.

Copy link
Member

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks! ❤️

Quick question. Does this support umbrella projects as well?

src/extension.ts Outdated Show resolved Hide resolved
@jayjun jayjun force-pushed the link branch 2 times, most recently from 99d21fb to f364fe4 Compare November 15, 2020 14:01
@jayjun
Copy link
Contributor Author

jayjun commented Nov 15, 2020

Yes, umbrella projects are supported. Given this stack trace

** (RuntimeError) runtime error
    (foo 0.1.0) lib/file.ex:16: Foo.crash_now/0

the extension will jump to apps/foo/lib/file.ex or lib/file.ex relative to the workspace root.

@axelson axelson merged commit 47c6845 into elixir-lsp:master Nov 15, 2020
@jayjun jayjun deleted the link branch November 16, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Umbrella test/build tasks path output isn't highlighted
2 participants