Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tools directory #97

Closed
peastman opened this issue Sep 25, 2024 · 2 comments
Closed

Missing tools directory #97

peastman opened this issue Sep 25, 2024 · 2 comments

Comments

@peastman
Copy link

I tried to use your precompiled libraries to build the minimal example at https://github.com/google/jax/blob/234be736c4cdd8da4197078278d35a6a1cde3767/examples/jax_cpp/main.cc. It fails because they don't include the xla/tools directory, which contains LoadModuleFromFile().

Would you consider adding it? That would make these libraries much more generally useful, not just for Elixer (though I understand that's the main purpose of them).

@josevalim
Copy link
Contributor

Thank you but we don’t have plans at the moment. It is very easy to inflate the binary size by adding deps we don’t need, which is why we plan to keep them minimal. :)

@josevalim josevalim closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2024
@peastman
Copy link
Author

Oh well, I understand. I figured it was worth asking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants