Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA: Refreshing when on a thread breaks back nav and loses timeline position #1187

Open
3 of 4 tasks
eamodio opened this issue Jan 15, 2023 · 3 comments
Open
3 of 4 tasks
Labels
c: bug Something isn't working s: pending triage Pending Triage

Comments

@eamodio
Copy link

eamodio commented Jan 15, 2023

Pre-Checks

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
  • Providing a screenshot or video to reproduce the issue or show visually what was meant.
  • I am willing to provide a PR.

Describe the bug

I (too often) end up trying to scroll up on a thread (or want to "pull to refresh" on the thread) and end up triggering the default Chrome (I'm on Android 13) pull-to-refresh on the thread. This breaks any backward navigation and context (timeline position, etc).

It would be great if there was an "app" implemented pull-to-refresh that wouldn't break the above or something. Related, because there are no spinners or other progress indicators when opening a thread, I end up triggering the above more often, because I think I should be able to scroll to get to the root thread, but it hasn't loaded yet.

Reproduction video or screenshot

No response

Additional Context

No response

@eamodio eamodio added c: bug Something isn't working s: pending triage Pending Triage labels Jan 15, 2023
@stackblitz
Copy link

stackblitz bot commented Jan 15, 2023

Solve in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

@edimitchel
Copy link
Collaborator

edimitchel commented Jan 16, 2023

Request close to the issue #653, right?

@eamodio
Copy link
Author

eamodio commented Jan 17, 2023

They are related but I don't think they are the same. Though depending on how that is fixed it might seem like it fixes this issue (and might for the most common use-case).

But if I had a bunch of navigations in my history and I refreshed that fix would only get me to the timeline, not where I actually came from

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working s: pending triage Pending Triage
Projects
None yet
Development

No branches or pull requests

2 participants