Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s should call percentDecode before matching segment #20

Closed
malaire opened this issue Oct 31, 2018 · 2 comments
Closed

s should call percentDecode before matching segment #20

malaire opened this issue Oct 31, 2018 · 2 comments
Labels
breaking would require a MAJOR release request

Comments

@malaire
Copy link

malaire commented Oct 31, 2018

Url.Parser.s doesn't percentDecode path segments for matching so it returns Nothing instead of match if percent-encoding is used.

@Erudition
Copy link

Erudition commented Jun 19, 2019

#16 , no?

@evancz evancz added breaking would require a MAJOR release request labels Feb 9, 2021
@evancz evancz changed the title Url.Parser.s gives wrong result when path segment uses percent-encoding s should call percentDecode before matching segment Feb 9, 2021
@malaire
Copy link
Author

malaire commented Feb 9, 2021

While according to RFC 3986 segments should be percent-decoded before matching, making e.g. segments %6f, %6F and o equivalent, according to newer URL Living Standard decoding is not done making those three segments non-equivalent.

The URL Living Standard is a bit vague about the intended behavior so here's an issue I opened about the standard and where I got answer that decoding should not be done: whatwg/url#565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking would require a MAJOR release request
Projects
None yet
Development

No branches or pull requests

3 participants