Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cron job to compress all the icons into one .zip file on a regular basis #4

Open
elrumo opened this issue Jul 17, 2022 · 5 comments

Comments

@elrumo
Copy link
Owner

elrumo commented Jul 17, 2022

No description provided.

@elrumo
Copy link
Owner Author

elrumo commented Jul 18, 2022

@elrumo elrumo changed the title Create crono job to compress all the icons into one .zip file on a regular basis Create cron job to compress all the icons into one .zip file on a regular basis Jul 18, 2022
@janbrasna
Copy link

Wouldn't a GH Action based on PR, merge or release be better than a cronjob? E. g. https://github.com/marketplace/actions/zip-release

@elrumo
Copy link
Owner Author

elrumo commented Nov 2, 2022

Wouldn't a GH Action based on PR, merge or release be better than a cronjob? E. g. https://github.com/marketplace/actions/zip-release

It would, the only issue is that I would need to remember to also upload the icons to GH each week, which I know I would forget. So I think a cronjob that fetches all the icons from the API, creates a ZIP and then pushes it to gh would make more sense. But I'm open to suggestions.

Also, the only reason I haven't done it yet is time. Now that I've added an icon suggestion system, I'll make this a top priority.

@janbrasna
Copy link

Ah sry, I wrongly inferred that the repository is the source of the actual icon assets, and they are just deployed from here to the site via the Nuxt build+deploy flows. If the "single point of truth" for the icon files is elsewhere, then please disregard my comment;)

@elrumo
Copy link
Owner Author

elrumo commented Nov 11, 2022

No worries, I did consider using GitHub as the single point of truth, but it's not flexible enough and would be quite hard to add metadata like categories and tags which it uses for search. I'm using Strapi for the backend and to host the icons and its relations. The website itself is hosted on Vercel and is the code you see on GitHub. I'm trying my best to remember to upload the icons on GitHub too. And thanks for the support too! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📝 Backlog
Development

No branches or pull requests

2 participants