Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes a game does not end #5

Closed
eltoder opened this issue Nov 17, 2024 · 0 comments · Fixed by #31
Closed

Sometimes a game does not end #5

eltoder opened this issue Nov 17, 2024 · 0 comments · Fixed by #31
Labels
bug Something isn't working

Comments

@eltoder
Copy link
Owner

eltoder commented Nov 17, 2024

Don't know how to reproduce, but I saw this myself and saw reports of this on discord.
@eltoder eltoder added the bug Something isn't working label Nov 17, 2024
eltoder added a commit that referenced this issue Nov 24, 2024
@eltoder
Finish games client-side
651b390 
Don't wait for finishGame to update game.status -- show the end game UI
when there are no more sets right away and show a spinner while waiting
for the backend to confirm.

Fixes #5
@eltoder eltoder mentioned this issue Nov 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Finish games client-side eltoder/setwithfriends
1 participant
@eltoder