Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

SEP-10: apply grace period to minTime constraint #331

Closed
JakeUrban opened this issue Sep 17, 2021 · 2 comments
Closed

SEP-10: apply grace period to minTime constraint #331

JakeUrban opened this issue Sep 17, 2021 · 2 comments
Assignees

Comments

@JakeUrban
Copy link

SEP-10: Apply grace period to minTime constraint

It is possible that the client machine's clock is behind the SEP-10 server machine's clock.

If this is the case, client applications calling readChallengeTx() may not be able to validate the challenge due to the challenge transaction's minimum timebound being greater than the client machine's current time.

Changes

readChallengeTx() or the equivalent function

  • Apply a 5-minute grace period to the minibum timebound check
    • i.e. the minimum timebound should be permitted to be at most 5 minutes in the future from the client machine's current time

Implementations

Both the JS and Go SDKs have been updated with these changes.

@JakeUrban
Copy link
Author

@elucidsoft elucidsoft self-assigned this Sep 20, 2021
@JakeUrban JakeUrban changed the title SEP-10: apply grace period to minTime constraint (SDF) SEP-10: apply grace period to minTime constraint Sep 29, 2021
@elucidsoft elucidsoft mentioned this issue Nov 24, 2022
3 tasks
@elucidsoft
Copy link
Owner

Merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants